Closed
Bug 1182966
Opened 9 years ago
Closed 9 years ago
Use nsTHashTable::Iterator in caps/
Categories
(Core :: Security: CAPS, defect)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: mccr8)
References
Details
Attachments
(3 files)
1.18 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
3.77 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
1.08 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Because iterators are so much nicer than enumerate functions. There is one occurrence of EnumerateEntries() in layout/{style,svg}/ to be dealt with.
Reporter | ||
Comment 1•9 years ago
|
||
> There is one occurrence of EnumerateEntries() in layout/{style,svg}/ to be
> dealt with.
Sorry, that should be "caps/", not "layout/{style,svg}/".
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → continuation
Assignee | ||
Comment 2•9 years ago
|
||
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa78f6832829
Attachment #8633497 -
Flags: review?(mrbkap)
Assignee | ||
Comment 3•9 years ago
|
||
While I was here, I threw in a few minor cleanups. For some reason, I needed the .get() when assigning from a refptr to a comptr.
Attachment #8633498 -
Flags: review?(mrbkap)
Assignee | ||
Comment 4•9 years ago
|
||
I'm not entirely sure what these do, but it seems like a bad idea to extend them.
Attachment #8633499 -
Flags: review?(mrbkap)
Updated•9 years ago
|
Attachment #8633497 -
Flags: review?(mrbkap) → review+
Updated•9 years ago
|
Attachment #8633498 -
Flags: review?(mrbkap) → review+
Updated•9 years ago
|
Attachment #8633499 -
Flags: review?(mrbkap) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c25cbd21c168 https://hg.mozilla.org/integration/mozilla-inbound/rev/7de43f04cd0a https://hg.mozilla.org/integration/mozilla-inbound/rev/20e4f7dcee9c
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c25cbd21c168 https://hg.mozilla.org/mozilla-central/rev/7de43f04cd0a https://hg.mozilla.org/mozilla-central/rev/20e4f7dcee9c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•