1183187 - Aspect ratio of favicon is incorrect on standalone client

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Adam Roach [:abr]]

Attachment: favicon-smash.png

When a link-clicker joins a room that has context, the favicon is rendered too narrow for its height. This issue appears to be more pronounced on Chrome than it is on Firefox.

See attached screenshot.

Comment 1

[Mark Banner (:standard8)]

Attachment: Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

The issue is we've got some shrink flex in there, and I think we really don't want to flex the size.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8636540 [details] [diff] [review]
Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

Review of attachment 8636540 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8e6bdb5af306

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e6bdb5af306

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8636540 [details] [diff] [review]
Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

Approval Request Comment
[Feature/regressing bug #]: Context for conversations
[User impact if declined]: If a website has a long word with no breaks in its name, then the Hello panel could display the favicon badly. This would also affect the display of context in the conversation window on aurora.
[Describe test coverage new/current, TreeHerder]: N/A css only
[Risks and why]: Low, minor css change.
[String/UUID change made/needed]: None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8636540 [details] [diff] [review]
Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

CSS and one-line fix only. Let's uplift to Aurora.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cda5252d2401