1183206 - Make about:newtab independent of Firefox

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Marina Samuel [:emtwo]]

This includes (but isn't limited to) the following:

1) Removing #ifdef or other pre-processor directives
2) Using window.postMessage instead of RemotePageManager for message passing.
3) Add message passing or find alternatives for Firefox-specific APIs used such as Services.jsm

Comment 1

[Marina Samuel [:emtwo]]

Attachment: WIP: Communication between iframe with about:newtab content and browser

Comment 2

[Marina Samuel [:emtwo]]

Newtab code that will be hosted can be found here: https://github.com/emtwo/remote-newtab

Comment 3

[Marina Samuel [:emtwo]]

Attachment: WIP 2: Communication between iframe with about:newtab content and browser

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

There's a lot of e10s work (i.e. bug 1021654) going on with about:newtab, you folks should coordinate.

Comment 5

[Marina Samuel [:emtwo]]

(In reply to Tim Taubert [:ttaubert] from comment #4)
> There's a lot of e10s work (i.e. bug 1021654) going on with about:newtab,
> you folks should coordinate.

We are co-ordinating with Ursula and Mike who are currently involved in bug 1021654 and I'm personally following that bug closely.

Everything in this bug is being built on top of bug 1021654.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Marina Samuel [:emtwo] from comment #5)
> We are co-ordinating with Ursula and Mike who are currently involved in bug
> 1021654 and I'm personally following that bug closely.
> 
> Everything in this bug is being built on top of bug 1021654.

That's great to hear, sorry for assuming otherwise. Didn't see a lot of e10s folks CC'ed here :)

Comment 8

[Marina Samuel [:emtwo]]

Attachment: WIP 3: Communication between iframe with about:newtab content and browser

Comment 9

[Marina Samuel [:emtwo]]

Attachment: WIP 4: Communication between iframe with about:newtab content and browser

Comment 10

[Marina Samuel [:emtwo]]

Attachment: WIP 5: Communication between iframe with about:newtab content and browser

Comment 11

[Marina Samuel [:emtwo]]

Let's include converting to promise messages and re-organizing js files as part of this bug.

We agreed on 3 subdirs of js:

./js/page (UI)
./js/backend (Service worker)
./js/lib (external libraries, tools, helper functions)

Comment 12

[Marina Samuel [:emtwo]]

Attachment: WIP 6: Communication between iframe with about:newtab content and browser

Comment 13

[Marina Samuel [:emtwo]]

This bug is resolved with the following commits:

https://github.com/mozilla/newtab-dev/commit/c8c6a496742e2a31c917a47b35e449a7fbbf7b9
https://github.com/mozilla/remote-newtab/compare/9ecf0d7...019cb8aa

Comment 14

[Marina Samuel [:emtwo]]

typo in second commit, should be: https://github.com/mozilla/remote-newtab/compare/9ecf0d7...019cb8a