1183257 - Remember Password prompt does not work on Twitch

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently there is no remember password prompt on Twitch.

Visit http://twitch.tv, sign-in, no dialog

Comment 1

[Aaron Train [:aaronmt]]

This is mentioned on Build #24 on ios-feedback

https://groups.google.com/a/mozilla.com/d/msgid/ios-feedback/CA%2B7ao4wuPbE63LL7CzmfrG%3DV0w-3qzA6FZ%3DJW9mibPYHT5eVpQ%40mail.gmail.com?utm_medium=email&utm_source=footer

Comment 2

[Richard Newman [:rnewman]]

Wes, could you investigate?

Comment 3

[Wesley Johnston (:wesj)]

This login is in an iframe. We intentionally don't inject the logins script in iframes yet, to avoid security issues there. We could though... I think?

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/837

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8641298 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/837

This looks good to me, but I think it needs multiple sets of eyes.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8641298 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/837

I'm not too familiar with our passwords-message-passing mechanism, but this is fine with me if it works. We can do a more thorough security review as part of bug 1172091.

Comment 7

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/871

Will land in v1.1.

Comment 8

[Aaron Train [:aaronmt]]

Tried applying on master locally but there's conflicts

Comment 9

[Stephan Leroux [:sleroux]]

Oops forgot to add a comment - looks like we can merge this after a rebase/Swift 2.0 update?

Comment 10

[Brian Nicholson (:bnicholson)]

Updated and merged.

https://github.com/mozilla/firefox-ios/commit/1844b83c55a2e182f0fabde5e8a32963677d61cd