1183379 - Add Amharic (am), Upper Sorbian (hsb), Lower Sorbian (dsb), Miahuatlán Zapotec (zam) locales to Gaia on master and 2.2 branches

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Théo Chevalier]

Let's gather in the same place all the locales we're adding so that we can reduce paperwork.
In the end, we're adding them all to the same branches so now it makes more sense to do one patch.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] TheoChevalier:new-gaia-locales > mozilla-b2g:master

Comment 4

[Théo Chevalier]

I made the assumption on my founding that translated name for zam was Zapoteco de Miahuatlán, still requires confirmation from localizers.

Comment 5

[Théo Chevalier]

Hey Rodrigo, one last question, could you check if I got the translated name of your locale right?

"Zapoteco de Miahuatlán" will be displayed in Settings to the user so that he can pick the language, is that correct for your locale?

Comment 6

[rodrigo_perez_r]

Hi Theo, is correct.

Comment 7

[Théo Chevalier]

Comment on attachment 8633159 [details] [review]
[gaia] TheoChevalier:new-gaia-locales > mozilla-b2g:master

Hey Stas, finally got the patch to review :)

Comment 8

[Théo Chevalier]

(In reply to rodrigo_perez_r from comment #6)
> Hi Theo, is correct.

Thanks!

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 8633159 [details] [review]
[gaia] TheoChevalier:new-gaia-locales > mozilla-b2g:master

Great to see so many new languages!  r=me.

Comment 10

[Théo Chevalier]

Thanks, stas!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/4729c9872220e4dd067814e3b41dde2737853c9f

Please request Gaia v2.2 approval on this when you get a chance.

Comment 12

[Théo Chevalier]

Hi Josh,

Delphine told me to NI you on this one.
Is that possible to uplift this patch to 2.2 please? This is low-risk and those locales are complete (or about to be complete), so that localizers can see their work and we can get them ready in case a partner requests any of them.

Comment 13

[Josh Cheng [:josh]]

(In reply to Théo Chevalier [:tchevalier] from comment #12)
> Hi Josh,
> 
> Delphine told me to NI you on this one.
> Is that possible to uplift this patch to 2.2 please? This is low-risk and
> those locales are complete (or about to be complete), so that localizers can
> see their work and we can get them ready in case a partner requests any of
> them.

Hi Theo,
Yes, I agree. Please help to raise uplift request for 2.2 Thanks!

Comment 14

[Théo Chevalier]

Comment on attachment 8633159 [details] [review]
[gaia] TheoChevalier:new-gaia-locales > mozilla-b2g:master

(Oops, forgot about this approval flag thing)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: am, dsb, hsb and zam locales can't be built-in in 2.2 builds.
[Testing completed]: Tested with latest master on Flame - new languages are available
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/8f3749f875c5ed155ccbd630aa2ee4e8bc2a9400