1183437 - Links from attachments to mozreview or github requests should show a [review] link which takes you to the attached url

Status: RESOLVED WONTFIX

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Mike Hommey [:glandium]]

Here is how I go through my review queue:
- I open the "My requests" page on bmo
- I go through the list of feedback, needinfo and review requests and for each of those that I want to do at that moment, I use the attachment link.

For pure bugzilla attachments, clicking gets me to the patch content (the raw attachment), or, when clicking on [review], gets me to splinter.

For mozreview attachments, there is no [review] link, and clicking gets me to https://reviewboard.mozilla.org/r/id, not https://reviewboard.mozilla.org/r/id/diff/, which means I'm still one click and one page load away from reviewing.

Relatedly, for github PR fake attachments, that also sends to the PR, not the diff view. I guess I should file a separate bug for that?

Comment 1

[Mark Côté [:mcote]]

Hm yeah, I'm addressing the lack of diff link in the MozReview table in bug 1123143, but having the attachment link itself go to the diff probably makes sense.  Or maybe we should finally get external code-review-tool links closer to being first-class citizens of Bugzilla, with [review] links and such.  I'll bring that up with the BMO devs.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

It seems to me this has been fixed?

Comment 3

[Kohei Yoshino [:kohei]]

MozReview is gone, and the GitHub PR support will be removed in Bug 1286448.