Closed Bug 1184077 Opened 9 years ago Closed 9 years ago

[NGA][Contacts] VCARD loader as independent page

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S5 (21Aug)
Tracking Status
b2g-master --- fixed

People

(Reporter: fcampo, Assigned: mancas)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file)

we need to load the vcards information and show it to the user without going through all the critical path for contacts, so we're able to open it directly from the corresponding activities.

Following the NGA approach, split logic and UX should be done.
Blocks: 1184070
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → FxOS-S3 (24Jul)
Target Milestone: FxOS-S3 (24Jul) → FxOS-S4 (07Aug)
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master

Hey Borja, can you take a look at the patch?
Attachment #8641542 - Flags: feedback?(borja.bugzilla)
Attachment #8641542 - Flags: feedback?(borja.bugzilla) → review?(fernando.campo)
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master

a few nits for code style, but works good on phone. great work Manu!!
Attachment #8641542 - Flags: review?(fernando.campo) → review+
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master

LGTM as well. Just fix Fernando's suggestions and we are done! :)
Attachment #8641542 - Flags: review+
Target Milestone: FxOS-S4 (07Aug) → FxOS-S5 (21Aug)
Landed in master: https://github.com/mozilla-b2g/gaia/commit/ed4586d6e6b24010b26484b32b372f8c7bcf63e7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: