Closed
Bug 1184103
Opened 9 years ago
Closed 9 years ago
[Control Center] Show grey lock icon when the connection is degraded
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
Tracking | Status | |
---|---|---|
firefox42 | --- | verified |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Whiteboard: [fxprivacy] [campaign])
Attachments
(1 file)
8.75 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
The connection degrades for weak ciphers (SSL3/RC4) and whenever mixed display content is loaded. The lock in the URL bar becomes grey and so should the big lock in the control center.
Assignee | ||
Comment 1•9 years ago
|
||
Weak Ciphers (RC4): https://rc4.badssl.com/ You probably need to set security.tls.unrestricted_rc4_fallback=true for that to work in Nightly. Mixed active content blocked and mixed passive content loaded: https://people.mozilla.org/~tvyas/mixedboth.html Mixed passive content loaded: https://people.mozilla.org/~tvyas/mixeddisplay.html
Attachment #8634058 -
Flags: review?(bgrinstead)
Updated•9 years ago
|
Rank: 4
Flags: qe-verify?
Flags: firefox-backlog+
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify? → qe-verify+
Updated•9 years ago
|
QA Contact: mwobensmith
Comment 2•9 years ago
|
||
Comment on attachment 8634058 [details] [diff] [review] 0001-Bug-1184103-Control-Center-Show-grey-lock-icon-when-.patch Review of attachment 8634058 [details] [diff] [review]: ----------------------------------------------------------------- Looks good and seems to match the spec at: https://www.dropbox.com/sh/1ebphwquhclq2cj/AAA4dMN8Wj16V99TcpMpqKURa/SSL%20and%20insecure%20States?dl=0. The commit message formatting needs to be updated and windows jar.mn file needs minor rebasing, but r=me
Attachment #8634058 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #2) > The commit message formatting needs to be updated That's how `git format-patch` outputs them. I always fix them by hand later :)
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f0f66da6c6fb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Updated•9 years ago
|
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Comment 6•9 years ago
|
||
Verified as fixed using: Win 7 x64, Mac Os X 10.8.5, Ubuntu 12.04 x86 FF 42 Build Id: 20150722030205
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•