Closed
Bug 1184382
Opened 9 years ago
Closed 9 years ago
XBL scope creation can fail if the associated window navigates at the wrong time
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
2.67 KB,
patch
|
gkrizsanits
:
review+
|
Details | Diff | Splinter Review |
This is what's biting us in bug 1180798. The basic problem is that the XBL scope is a sandbox that's supposed to be tightly associated with a given inner window. But because it all happens in JS-land, the reference ends up being an outer, and navigation can cause the XBL scope to end up with a sandboxPrototype it can't subsumes. I'll attach a patch that manually handles the immediate problem. It'd sure be nice to have some sort of direct inner window reference in JS though.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8634463 -
Flags: review?(gkrizsanits)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=850d1b6fb2cc
Comment 3•9 years ago
|
||
> It'd sure be nice to have some sort of direct inner window reference in JS though.
Yes, yes, it would. There are lots of cases where having some proxy that directly forwards stuff to an inner would be quite helpful. JS-implemented WebIDL components, for example...
I wonder whether we could just build a C++ proxy that does the right thing here.
Comment 4•9 years ago
|
||
Comment on attachment 8634463 [details] [diff] [review] Handle a sandboxPrototype we don't subsume. v1 Review of attachment 8634463 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for looking into this.
Attachment #8634463 -
Flags: review?(gkrizsanits) → review+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eb26fd0f023c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•