1184786 - WebGL 2 - ReadBuffer returns incorrect errors

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

ReadBuffer is returning the incorrect error type when checking parameters.

Comment 1

[u480271]

Attachment: Fix LastColorAttachment().

Comment 2

[u480271]

Attachment: Fix ReadBuffer parameter validation.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8635036 [details] [diff] [review]
Fix ReadBuffer parameter validation.

Review of attachment 8635036 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextFramebuffers.cpp
@@ +585,3 @@
>  
>      if (mBoundReadFramebuffer) {
> +        if (src == LOCAL_GL_BACK) {

I would rather test explicitly what it says below, instead of testing against what (for now?) is the only alternative.

@@ +599,5 @@
>      // Operating on the default framebuffer.
> +    if (isColorAttachment) {
> +        ErrorInvalidOperation("readBuffer: If READ_FRAMEBUFFER is null, `src`"
> +                              " must be BACK or NONE. Was %s",
> +                              EnumName(src));

Again, I'd rather test explicitly what is requested to test, rather than process-of-elimination. (prone to breakage when things above it change)

Comment 4

[u480271]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=81413e960456

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5834e85fc660
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c777aabd5d0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5834e85fc660
https://hg.mozilla.org/mozilla-central/rev/0c777aabd5d0