Closed Bug 1184796 Opened 9 years ago Closed 6 years ago

Explore ways to combine output from bidi-style/value Stulys mixin

Categories

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Product:
developer.mozilla.org Graveyard
Component:
Code Cleanup
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: shobson, Unassigned)

Details

Current behaviour:

.test {
    bidi-value(float, left, right);
    bidi-value(text-align, left, right);
}

Outputs:

.test {
    float:left;
    text-align: left;
}
html[dir='rtl'] .test {
    float: right;
}
html[dir='rtl'] .test {
    text-align: right;
}

Ideal output: 

.test {
    float:left;
    text-align: left;
}
html[dir='rtl'] .test {
    float: right;
    text-align: right;
}

The solution to this may not lie with Stylus, we might be able to tweak the minifier to do it.
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7e83c6bebdfb7f86087f5c8d4092a813a9cbf788
Fix bug 1184796: Optimize bibi mixin for multiple declarations (#4569)

- create bidi() mixin
- update all bidi-value and bidi-style includes to use bidi()
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.