1184822 - [Graphene] SystemUpdateService.jsm: line 30: NS_ERROR_XPC_GS_RETURNED_FAILURE

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Paul Rouget [:paul]]

Happens at startup, on my B2G build.

This component toolkit/mozapps/update/nsUpdateService.js is used instead of this one b2g/components/UpdatePrompt.js. They both register as "@mozilla.org/updates/update-service;1".

I don't know how xpcom components registration works exactly, but it's dangerous to have 2 components with the same id.

nsUpdateService.js should probably be disabled on B2G.

Comment 1

[James Cheng[:JamesCheng]]

Hi Paul,

Could you please paste your mozconfig for me?

I would like to know why you encounter this issue but I cannot reproduce.

Thanks.

Comment 2

[Paul Rouget [:paul]]

Nothing but:

ac_add_options --enable-application=b2g

I use:

./mach build && ./mach run

Comment 3

[Paul Rouget [:paul]]

It appears to be a Graphene specific issue.

I've been told to use B2G_UPDATER=1 and not MOZ_UPDATER.

Fabrice, you know better up how the update works for Graphene. Should we use the mechanism introduced in bug 1037329 or keep the original toolkit mechanism?

Comment 4

[Paul Rouget [:paul]]

Attachment: B2G_UPDATER

This solves my issue, but I don't know how it plays Graphene's update.

Comment 5

[James Cheng[:JamesCheng]]

Attachment: setting-active-provider-only-on-gonk-platform

When |ac_add_options --enable-updater|
The MOZ_UPDATER will be defined.
And we will get the wrong updater on b2g desktop.
To solve this problem, we set the active provider in settings only on Gonk platform.
Hi Fabrice,
Please help to review this change. 
Thank you very much.

Comment 6

[Paul Rouget [:paul]]

Went ahead an landed James' patch in Larch: https://hg.mozilla.org/projects/larch/rev/cc36d99ddad2

There's not r+ yet, Fabrice is on holidays, but I got Fabrice's verbal approval to land patches in larch with no review.

Comment 7

[James Cheng[:JamesCheng]]

Hi Paul,

This patch should also land into Mozilla central  master.

Do you know when Fabrics will be back from holiday?

Or do you know anyone who can also review this patch?

Thank you!

Comment 8

[Paul Rouget [:paul]]

(In reply to James Cheng[:JamesCheng] from comment #7)
> Hi Paul,
> 
> This patch should also land into Mozilla central master.
> 
> Do you know when Fabrics will be back from holiday?

The 27th.

> Or do you know anyone who can also review this patch?

Not me. :gerard-majax can probably do it.

Comment 9

[James Cheng[:JamesCheng]]

Hi Gerard-majax,

Could you please review this patch?

Thanks.

Comment 10

[:gerard-majax]

I'm not a peer for this, but it looks good. Dave did reviews on UpdatePrompt.js code for B2G and he's back from PTO tomorrow, maybe he can?

Comment 11

[James Cheng[:JamesCheng]]

Thanks Alexandre.

Hi Dave, if you can help to review this patch, i will modify the reviewer to you.

Thank you for your help~

Comment 12

[James Cheng[:JamesCheng]]

Attach treeherder for reference, 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=87e9d151e904

Comment 13

[Dave Hylands [:dhylands]]

What's Graphene?

B2G's mozconfig expects B2G_UPDATER to be set to 1, which will in turn do this:
https://github.com/mozilla-b2g/gonk-misc/blob/master/default-gecko-config#L53-L58
which enables MOZ_UPDATER

I don't think anybody has ever tested updates on b2g-desktop. To the best of my knowledge this isn't something that we've ever needed to support.

B2G definitely uses both toolkit/mozapps/update/nsUpdateService.js and b2g/components/UpdatePrompt.js

Since the patch only seems to affect b2g-desktop (I think that's the only B2G platform we build where MOZ_WIDGET_GONK is not set), the patch looks fine to me.

Comment 14

[James Cheng[:JamesCheng]]

Attachment: Bug-1184822-setting-active-provider-only-on-gonk-pla.patch

Update the reviewer to r=dhylands
Hi Dave,
Thanks for your feedback.
Please help me for reviewing this patch.

Thanks.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97a66defe146

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97a66defe146

Comment 17

[[:fabrice] Fabrice Desré]

Initial investigation shows that we only fail to start with non packaged builds (unfortunately these are the ones we use for development). In packages, everything works fine without this patch.

I'm gonna look into fixing dev builds that properly, and revert the current change.

Comment 18

[[:fabrice] Fabrice Desré]

Hm, so actually with a build in $objdir:

Launching graphene from $objdir/dist/bin/graphene, MOZ_UPDATER is not set and we fail (I guess this is what Paul hit).

Launching graphene from $objdir/dist/graphene/graphene everything works fine. I'm switching to that locally.

So I'm gonna back out this patch because I don't think we need it, and even if we need something this is not the right fix.

Comment 19

[[:fabrice] Fabrice Desré]

backed out in https://hg.mozilla.org/integration/b2g-inbound/rev/5def9fe21067

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/5def9fe21067

Comment 21

[Eric Tsai (no more review request accepted)]

Attachment: bug1184822-use-classid-to-get-provider.diff

I encounter the same problem when build b2g-desktop with enable-updater.
https://dxr.mozilla.org/mozilla-central/source/dom/system/SystemUpdateService.js
Using contractId get component from nsUpdateService.js, is not a nsISystemUpdateProvider. The patch uses classId to get correct component from UpdatePrompt.js.

Comment 22

[Eric Tsai (no more review request accepted)]

Checkin-needed for attachment 8644120 [details] [diff] [review]
Try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=45a550b95132

Comment 24

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/b5b865a45414

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5b865a45414