1184869 - [Settings] Support new MozMobileMessage.getSmscAddress() function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Samael Wang [:freesamael] (away for now)]

The return type of MozMobileMessage.getSmscAddress() will be changed to Promise<SmscAddress> in Bug 1043250. Gaia should be able to support both Promise and legacy DOMRequest interfaces by adapting DOMRequest.then().

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] freesamael:bz/1184869-on-2f36e9c > mozilla-b2g:master

Comment 2

[Samael Wang [:freesamael] (away for now)]

Comment on attachment 8635912 [details] [review]
[gaia] freesamael:bz/1184869-on-2f36e9c > mozilla-b2g:master

Hi Evelyn,

The original interface of MozMobileMessage.getSmscAddress() resolves to a string consisting of whatever the underlying modem returns.

Gaia assumes the return value to be in text mode, but some devices report SMSC in PDU mode and cause the displayed SMSC address in Settings becomes unreadable on those devices.

To resolve this problem, in Bug 1043250 we're change the interface from

> DOMRequest getSmscAddress(optional unsigned long serviceId);

to

> Promise<SmscAddress> getSmscAddress(optional unsigned long serviceId);

The Gaia part has to be updated as well in order to support both implementations. Could you help to review the patch I made in Gaia for this purpose, or give me some feedbacks on it?

Comment 3

[Evelyn Hung]

Comment on attachment 8635912 [details] [review]
[gaia] freesamael:bz/1184869-on-2f36e9c > mozilla-b2g:master

r+ with nit addressed. Thanks.

Comment 4

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/b5f1d448f17e9a8a920d40d169eba12cfac2d0c5