Closed
Bug 1185499
Opened 9 years ago
Closed 9 years ago
Please split Linux debug xpcshell into at least 2 chunks
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RyanVM, Assigned: jgriffin)
Details
Attachments
(1 file, 1 obsolete file)
11.79 KB,
patch
|
catlee
:
review+
jgriffin
:
checked-in+
|
Details | Diff | Splinter Review |
Linux32 debug xpcshell is routinely hitting 7200s timeouts these days (see bug 1073442). In order to keep this suite unhidden, we need to split it into chunks. Linux64 is running consistently at 100+ min as well, so we might as well do both at the same time. This is high-priority as we'll have to hide the suite otherwise.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jgriffin
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Builders added: + Ubuntu VM 12.04 alder debug test xpcshell-1 buntu VM 12.04 x64 mozilla-central debug test xpcshell VM 12.04 ash debug test xpcshell-1 nd debug test xpcshell ebug test xpcshell-2 oak debug test xpcshell ound debug test xpcshell-1 ebug test xpcshell 2g-inbound debug test xpcshell-2 + Ubuntu VM 12.04 cedar debug test xpcshell-1 + Ubuntu VM 12.04 cedar debug test xpcshell-2 + Ubuntu VM 12.04 elm debug test xpcshell-1 + Ubuntu VM 12.04 elm debug test xpcshell-2 + Ubuntu VM 12.04 fx-team debug test xpcshell-1 + Ubuntu VM 12.04 fx-team debug test xpcshell-2 + Ubuntu VM 12.04 gum debug test xpcshell-1 + Ubuntu VM 12.04 gum debug test xpcshell-2 + Ubuntu VM 12.04 holly debug test xpcshell-1 + Ubuntu VM 12.04 holly debug test xpcshell-2 + Ubuntu VM 12.04 jamun debug test xpcshell-1 + Ubuntu VM 12.04 jamun debug test xpcshell-2 + Ubuntu VM 12.04 maple debug test xpcshell-1 + Ubuntu VM 12.04 maple debug test xpcshell-2 + Ubuntu VM 12.04 mozilla-aurora debug test xpcshell-1 + Ubuntu VM 12.04 mozilla-aurora debug test xpcshell-2 + Ubuntu VM 12.04 mozilla-central debug test xpcshell-1 + Ubuntu VM 12.04 mozilla-central debug test xpcshell-2 + Ubuntu VM 12.04 mozilla-inbound debug test xpcshell-1 + Ubuntu VM 12.04 mozilla-inbound debug test xpcshell-2 + Ubuntu VM 12.04 oak debug test xpcshell-1 + Ubuntu VM 12.04 oak debug test xpcshell-2 + Ubuntu VM 12.04 try debug test xpcshell-1 + Ubuntu VM 12.04 try debug test xpcshell-2 + Ubuntu VM 12.04 x64 alder debug test xpcshell-1 + Ubuntu VM 12.04 x64 alder debug test xpcshell-2 + Ubuntu VM 12.04 x64 ash debug test xpcshell-1 + Ubuntu VM 12.04 x64 ash debug test xpcshell-2 + Ubuntu VM 12.04 x64 b2g-inbound debug test xpcshell-1 + Ubuntu VM 12.04 x64 b2g-inbound debug test xpcshell-2 + Ubuntu VM 12.04 x64 cedar debug test xpcshell-1 + Ubuntu VM 12.04 x64 cedar debug test xpcshell-2 + Ubuntu VM 12.04 x64 elm debug test xpcshell-1 + Ubuntu VM 12.04 x64 elm debug test xpcshell-2 + Ubuntu VM 12.04 x64 fx-team debug test xpcshell-1 + Ubuntu VM 12.04 x64 fx-team debug test xpcshell-2 + Ubuntu VM 12.04 x64 gum debug test xpcshell-1 + Ubuntu VM 12.04 x64 gum debug test xpcshell-2 + Ubuntu VM 12.04 x64 holly debug test xpcshell-1 + Ubuntu VM 12.04 x64 holly debug test xpcshell-2 + Ubuntu VM 12.04 x64 jamun debug test xpcshell-1 + Ubuntu VM 12.04 x64 jamun debug test xpcshell-2 + Ubuntu VM 12.04 x64 maple debug test xpcshell-1 + Ubuntu VM 12.04 x64 maple debug test xpcshell-2 + Ubuntu VM 12.04 x64 mozilla-aurora debug test xpcshell-1 + Ubuntu VM 12.04 x64 mozilla-aurora debug test xpcshell-2 + Ubuntu VM 12.04 x64 mozilla-central debug test xpcshell-1 + Ubuntu VM 12.04 x64 mozilla-central debug test xpcshell-2 + Ubuntu VM 12.04 x64 mozilla-inbound debug test xpcshell-1 + Ubuntu VM 12.04 x64 mozilla-inbound debug test xpcshell-2 + Ubuntu VM 12.04 x64 oak debug test xpcshell-1 + Ubuntu VM 12.04 x64 oak debug test xpcshell-2 + Ubuntu VM 12.04 x64 try debug test xpcshell-1 + Ubuntu VM 12.04 x64 try debug test xpcshell-2 Builders removed - Ubuntu VM 12.04 alder debug test xpcshell - Ubuntu VM 12.04 ash debug test xpcshell - Ubuntu VM 12.04 b2g-inbound debug test xpcshell - Ubuntu VM 12.04 cedar debug test xpcshell - Ubuntu VM 12.04 elm debug test xpcshell - Ubuntu VM 12.04 fx-team debug test xpcshell - Ubuntu VM 12.04 gum debug test xpcshell - Ubuntu VM 12.04 jamun debug test xpcshell - Ubuntu VM 12.04 maple debug test xpcshell - Ubuntu VM 12.04 mozilla-aurora debug test xpcshell - Ubuntu VM 12.04 mozilla-central debug test xpcshell - Ubuntu VM 12.04 mozilla-inbound debug test xpcshell - Ubuntu VM 12.04 oak debug test xpcshell - Ubuntu VM 12.04 try debug test xpcshell - Ubuntu VM 12.04 x64 alder debug test xpcshell - Ubuntu VM 12.04 x64 ash debug test xpcshell - Ubuntu VM 12.04 x64 b2g-inbound debug test xpcshell - Ubuntu VM 12.04 x64 cedar debug test xpcshell - Ubuntu VM 12.04 x64 elm debug test xpcshell - Ubuntu VM 12.04 x64 fx-team debug test xpcshell - Ubuntu VM 12.04 x64 gum debug test xpcshell - Ubuntu VM 12.04 x64 jamun debug test xpcshell - Ubuntu VM 12.04 x64 maple debug test xpcshell - Ubuntu VM 12.04 x64 mozilla-aurora debug test xpcshell - Ubuntu VM 12.04 x64 mozilla-central debug test xpcshell - Ubuntu VM 12.04 x64 mozilla-inbound debug test xpcshell - Ubuntu VM 12.04 x64 oak debug test xpcshell - Ubuntu VM 12.04 x64 try debug test xpcshell
Attachment #8636073 -
Flags: review?(catlee)
Assignee | ||
Comment 2•9 years ago
|
||
Uh, not sure what happened to that list, here it is again: Builders added: + Ubuntu VM 12.04 alder debug test xpcshell-1 + Ubuntu VM 12.04 alder debug test xpcshell-2 + Ubuntu VM 12.04 ash debug test xpcshell-1 + Ubuntu VM 12.04 ash debug test xpcshell-2 + Ubuntu VM 12.04 b2g-inbound debug test xpcshell-1 + Ubuntu VM 12.04 b2g-inbound debug test xpcshell-2 + Ubuntu VM 12.04 cedar debug test xpcshell-1 + Ubuntu VM 12.04 cedar debug test xpcshell-2 + Ubuntu VM 12.04 elm debug test xpcshell-1 + Ubuntu VM 12.04 elm debug test xpcshell-2 + Ubuntu VM 12.04 fx-team debug test xpcshell-1 + Ubuntu VM 12.04 fx-team debug test xpcshell-2 + Ubuntu VM 12.04 gum debug test xpcshell-1 + Ubuntu VM 12.04 gum debug test xpcshell-2 + Ubuntu VM 12.04 holly debug test xpcshell-1 + Ubuntu VM 12.04 holly debug test xpcshell-2 + Ubuntu VM 12.04 jamun debug test xpcshell-1 + Ubuntu VM 12.04 jamun debug test xpcshell-2 + Ubuntu VM 12.04 maple debug test xpcshell-1 + Ubuntu VM 12.04 maple debug test xpcshell-2 + Ubuntu VM 12.04 mozilla-aurora debug test xpcshell-1 + Ubuntu VM 12.04 mozilla-aurora debug test xpcshell-2 + Ubuntu VM 12.04 mozilla-central debug test xpcshell-1 + Ubuntu VM 12.04 mozilla-central debug test xpcshell-2 + Ubuntu VM 12.04 mozilla-inbound debug test xpcshell-1 + Ubuntu VM 12.04 mozilla-inbound debug test xpcshell-2 + Ubuntu VM 12.04 oak debug test xpcshell-1 + Ubuntu VM 12.04 oak debug test xpcshell-2 + Ubuntu VM 12.04 try debug test xpcshell-1 + Ubuntu VM 12.04 try debug test xpcshell-2 + Ubuntu VM 12.04 x64 alder debug test xpcshell-1 + Ubuntu VM 12.04 x64 alder debug test xpcshell-2 + Ubuntu VM 12.04 x64 ash debug test xpcshell-1 + Ubuntu VM 12.04 x64 ash debug test xpcshell-2 + Ubuntu VM 12.04 x64 b2g-inbound debug test xpcshell-1 + Ubuntu VM 12.04 x64 b2g-inbound debug test xpcshell-2 + Ubuntu VM 12.04 x64 cedar debug test xpcshell-1 + Ubuntu VM 12.04 x64 cedar debug test xpcshell-2 + Ubuntu VM 12.04 x64 elm debug test xpcshell-1 + Ubuntu VM 12.04 x64 elm debug test xpcshell-2 + Ubuntu VM 12.04 x64 fx-team debug test xpcshell-1 + Ubuntu VM 12.04 x64 fx-team debug test xpcshell-2 + Ubuntu VM 12.04 x64 gum debug test xpcshell-1 + Ubuntu VM 12.04 x64 gum debug test xpcshell-2 + Ubuntu VM 12.04 x64 holly debug test xpcshell-1 + Ubuntu VM 12.04 x64 holly debug test xpcshell-2 + Ubuntu VM 12.04 x64 jamun debug test xpcshell-1 + Ubuntu VM 12.04 x64 jamun debug test xpcshell-2 + Ubuntu VM 12.04 x64 maple debug test xpcshell-1 + Ubuntu VM 12.04 x64 maple debug test xpcshell-2 + Ubuntu VM 12.04 x64 mozilla-aurora debug test xpcshell-1 + Ubuntu VM 12.04 x64 mozilla-aurora debug test xpcshell-2 + Ubuntu VM 12.04 x64 mozilla-central debug test xpcshell-1 + Ubuntu VM 12.04 x64 mozilla-central debug test xpcshell-2 + Ubuntu VM 12.04 x64 mozilla-inbound debug test xpcshell-1 + Ubuntu VM 12.04 x64 mozilla-inbound debug test xpcshell-2 + Ubuntu VM 12.04 x64 oak debug test xpcshell-1 + Ubuntu VM 12.04 x64 oak debug test xpcshell-2 + Ubuntu VM 12.04 x64 try debug test xpcshell-1 + Ubuntu VM 12.04 x64 try debug test xpcshell-2 Builders removed - Ubuntu VM 12.04 alder debug test xpcshell - Ubuntu VM 12.04 ash debug test xpcshell - Ubuntu VM 12.04 b2g-inbound debug test xpcshell - Ubuntu VM 12.04 cedar debug test xpcshell - Ubuntu VM 12.04 elm debug test xpcshell - Ubuntu VM 12.04 fx-team debug test xpcshell - Ubuntu VM 12.04 gum debug test xpcshell - Ubuntu VM 12.04 jamun debug test xpcshell - Ubuntu VM 12.04 maple debug test xpcshell - Ubuntu VM 12.04 mozilla-aurora debug test xpcshell - Ubuntu VM 12.04 mozilla-central debug test xpcshell - Ubuntu VM 12.04 mozilla-inbound debug test xpcshell - Ubuntu VM 12.04 oak debug test xpcshell - Ubuntu VM 12.04 try debug test xpcshell - Ubuntu VM 12.04 x64 alder debug test xpcshell - Ubuntu VM 12.04 x64 ash debug test xpcshell - Ubuntu VM 12.04 x64 b2g-inbound debug test xpcshell - Ubuntu VM 12.04 x64 cedar debug test xpcshell - Ubuntu VM 12.04 x64 elm debug test xpcshell - Ubuntu VM 12.04 x64 fx-team debug test xpcshell - Ubuntu VM 12.04 x64 gum debug test xpcshell - Ubuntu VM 12.04 x64 jamun debug test xpcshell - Ubuntu VM 12.04 x64 maple debug test xpcshell - Ubuntu VM 12.04 x64 mozilla-aurora debug test xpcshell - Ubuntu VM 12.04 x64 mozilla-central debug test xpcshell - Ubuntu VM 12.04 x64 mozilla-inbound debug test xpcshell - Ubuntu VM 12.04 x64 oak debug test xpcshell - Ubuntu VM 12.04 x64 try debug test xpcshell
Assignee | ||
Comment 3•9 years ago
|
||
try run to make sure nothing blows up when xpcshell is chunked: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2537d27619f4
Comment 4•9 years ago
|
||
Comment on attachment 8636073 [details] [diff] [review] Split linux32/64 debug xpcshell into two chunks, Review of attachment 8636073 [details] [diff] [review]: ----------------------------------------------------------------- How hard would it be to flip this around so that the multiple chunk configuration is the default, and we make exceptions for older branches to run the single chunk config?
Assignee | ||
Comment 5•9 years ago
|
||
Here's the patch which defaults to two chunks on linux32/64 debug, but special-cases gecko < 41.
Attachment #8636143 -
Flags: review?(catlee)
Assignee | ||
Updated•9 years ago
|
Attachment #8636073 -
Attachment is obsolete: true
Attachment #8636073 -
Flags: review?(catlee)
Assignee | ||
Comment 6•9 years ago
|
||
Sadly, this causes X2 to go perma-fail: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2537d27619f4 Bill, any idea why splitting xpcshell into two chunks would cause this? Is there possibly a dependency between extensions/cookie/test/unit_ipc/test_parent.js and another xpcshell test?
Flags: needinfo?(wmccloskey)
I think this is a recent regression from bug 1184397. It looks like we initialize the permissions manager in both the parent and the child: http://mxr.mozilla.org/mozilla-central/source/extensions/cookie/nsPermissionManager.cpp#656 (note the IsChildProcessCheck). However, ::Observe asserts that it only runs in the parent. However, xpcom-shutdown can fire in the child. Ehsan, could you sort this out?
Flags: needinfo?(wmccloskey) → needinfo?(ehsan)
Comment 8•9 years ago
|
||
Please push to try again, your previous push is on a broken patch that was backed out.
Flags: needinfo?(ehsan)
Assignee | ||
Comment 9•9 years ago
|
||
Thanks, rebased and pushed to try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e8154fda0da
Updated•9 years ago
|
Attachment #8636143 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 10•9 years ago
|
||
The try runs look good now.
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8636143 [details] [diff] [review] Split linux32/64 debug xpcshell into two chunks, https://hg.mozilla.org/build/buildbot-configs/rev/3701f9b8de82
Attachment #8636143 -
Flags: checked-in+
Comment 12•9 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/3701f9b8de82
Comment 13•9 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/8f9ec68b1af7
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•