1185583 - Thunderbird broken by mozilla-central Bug 1143922 nsPop3Protocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::Open2(class nsIInputStream * *)" (?Open2@nsMsgProtocol@@UAG?AW4nsresult@@PAPAVnsIInput

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Philip Chee]

nsPop3Protocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::Open2(class nsIInputStream * *)" (?Open2@nsMsgProtocol@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsNNTPProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::Open2(class nsIInputStream * *)" (?Open2@nsMsgProtocol@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsMsgProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::Open2(class nsIInputStream * *)" (?Open2@nsMsgProtocol@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsSmtpProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::Open2(class nsIInputStream * *)" (?Open2@nsMsgProtocol@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsImapProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::Open2(class nsIInputStream * *)" (?Open2@nsMsgProtocol@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsMailboxProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::Open2(class nsIInputStream * *)" (?Open2@nsMsgProtocol@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsPop3Protocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsMsgProtocol@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
nsNNTPProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsMsgProtocol@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
nsMsgProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsMsgProtocol@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
nsSmtpProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsMsgProtocol@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
nsImapProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsMsgProtocol@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
nsMailboxProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgProtocol::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsMsgProtocol@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
nsImapProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsImapMockChannel::Open2(class nsIInputStream * *)" (?Open2@nsImapMockChannel@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsImapProtocol.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsImapMockChannel::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsImapMockChannel@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
nsNntpMockChannel.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsNntpMockChannel::Open2(class nsIInputStream * *)" (?Open2@nsNntpMockChannel@@UAG?AW4nsresult@@PAPAVnsIInputStream@@@Z)
nsNntpMockChannel.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsNntpMockChannel::AsyncOpen2(class nsIStreamListener *)" (?AsyncOpen2@nsNntpMockChannel@@UAG?AW4nsresult@@PAVnsIStreamListener@@@Z)
xul.dll : fatal error LNK1120: 6 unresolved externals
c:/t1/hg/comm-central/mozilla/config/rules.mk:826: recipe for target 'xul.dll' failed

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed Fix.

I'm just guessing that we don't really need those security checks so I've added Open2() and AsyncOpen2() that just forwards to Open() and AsyncOpen()

Comment 2

[Philip Chee]

Anyone wants to take over this bug please feel free. I've run out of time.

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21135
repository: comm-central
start_time: 2015-07-20T12:36:36
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-130
buildname: TB Linux comm-central build
revision: 3ec8d1385b80

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21132
repository: comm-central
start_time: 2015-07-20T12:36:35
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-222
buildname: TB Linux x86-64 comm-central build
revision: 3ec8d1385b80

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21133
repository: comm-central
start_time: 2015-07-20T12:36:24
who: ewong[at]pw-wspx[dot]org
machine: bld-lion-r5-056
buildname: TB OS X 10.7 comm-central build
revision: 3ec8d1385b80

make[6]: *** [XUL] Error 1
make[5]: *** [toolkit/library/target] Error 2
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [build] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21139
repository: comm-central
start_time: 2015-07-20T12:36:36
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-064
buildname: TB Linux x86-64 comm-central leak test build
revision: 3ec8d1385b80

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21134
repository: comm-central
start_time: 2015-07-20T12:36:34
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-134
buildname: TB Linux comm-central leak test build
revision: 3ec8d1385b80

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21137
repository: comm-central
start_time: 2015-07-20T12:36:24
who: ewong[at]pw-wspx[dot]org
machine: bld-lion-r5-053
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: 3ec8d1385b80

"%s: 0x%p FATAL ERROR\n", logname, lr, 0 );
make[5]: *** [XUL] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21138
repository: comm-central
start_time: 2015-07-20T12:36:24
who: ewong[at]pw-wspx[dot]org
machine: b-2008-ix-0004
buildname: TB WINNT 5.2 comm-central build
revision: 3ec8d1385b80

xul.dll : fatal error LNK1120: 6 unresolved externals
mozmake.exe[5]: *** [xul.dll] Error 1120
mozmake.exe[4]: *** [toolkit/library/target] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21126
repository: comm-central
start_time: 2015-07-20T12:27:45
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-088
buildname: TB Linux x86-64 comm-central leak test build
revision: 5f78a96a1486

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21131
repository: comm-central
start_time: 2015-07-20T12:27:38
who: ewong[at]pw-wspx[dot]org
machine: bld-lion-r5-074
buildname: TB OS X 10.7 comm-central build
revision: 5f78a96a1486

/builds/slave/tb-c-cen-m64-00000000000000000/build/mailnews/mime/cthandlers/pgpmime/nsPgpMimeProxy.cpp:130:1: error: expected string literal for diagnostic message in static_assert
/builds/slave/tb-c-cen-m64-00000000000000000/build/mailnews/mime/cthandlers/pgpmime/nsPgpMimeProxy.cpp:224:1: error: expected string literal for diagnostic message in static_assert
make[6]: *** [nsPgpMimeProxy.o] Error 1
make[5]: *** [mailnews/mime/cthandlers/pgpmime/target] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [build] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21129
repository: comm-central
start_time: 2015-07-20T12:27:45
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-033
buildname: TB Linux comm-central build
revision: 5f78a96a1486

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21136
repository: comm-central
start_time: 2015-07-20T12:36:24
who: ewong[at]pw-wspx[dot]org
machine: b-2008-ix-0154
buildname: TB WINNT 5.2 comm-central leak test build
revision: 3ec8d1385b80

xul.dll : fatal error LNK1120: 6 unresolved externals
mozmake.exe[5]: *** [xul.dll] Error 1120
mozmake.exe[4]: *** [toolkit/library/target] Error 2
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21124
repository: comm-central
start_time: 2015-07-20T12:27:39
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-098
buildname: TB Linux x86-64 comm-central build
revision: 5f78a96a1486

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 15

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21123
repository: comm-central
start_time: 2015-07-20T12:27:50
who: ewong[at]pw-wspx[dot]org
machine: b-2008-ix-0103
buildname: TB WINNT 5.2 comm-central leak test build
revision: 5f78a96a1486

xul.dll : fatal error LNK1120: 6 unresolved externals
mozmake.exe[5]: *** [xul.dll] Error 1120
mozmake.exe[4]: *** [toolkit/library/target] Error 2
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 16

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21128
repository: comm-central
start_time: 2015-07-20T12:27:44
who: ewong[at]pw-wspx[dot]org
machine: b-2008-ix-0166
buildname: TB WINNT 5.2 comm-central build
revision: 5f78a96a1486

xul.dll : fatal error LNK1120: 6 unresolved externals
mozmake.exe[5]: *** [xul.dll] Error 1120
mozmake.exe[4]: *** [toolkit/library/target] Error 2
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 17

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21125
repository: comm-central
start_time: 2015-07-20T12:27:34
who: ewong[at]pw-wspx[dot]org
machine: bld-lion-r5-043
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: 5f78a96a1486

/builds/slave/tb-c-cen-m64-d-000000000000000/build/mailnews/mime/cthandlers/pgpmime/nsPgpMimeProxy.cpp:130:1: error: expected string literal for diagnostic message in static_assert
/builds/slave/tb-c-cen-m64-d-000000000000000/build/mailnews/mime/cthandlers/pgpmime/nsPgpMimeProxy.cpp:224:1: error: expected string literal for diagnostic message in static_assert
make[5]: *** [nsPgpMimeProxy.o] Error 1
make[4]: *** [mailnews/mime/cthandlers/pgpmime/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 18

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=21127
repository: comm-central
start_time: 2015-07-20T12:27:47
who: ewong[at]pw-wspx[dot]org
machine: bld-linux64-spot-175
buildname: TB Linux comm-central leak test build
revision: 5f78a96a1486

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[5]: *** [libxul.so] Error 1
make[4]: *** [toolkit/library/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 19

[Edmund Wong (:ewong)]

Attachment: proposed patch (v1) (wip)

Comment 20

[Edmund Wong (:ewong)]

Comment on attachment 8636352 [details] [diff] [review]
proposed patch (v1) (wip)

Review of attachment 8636352 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/util/nsMsgProtocol.cpp
@@ +514,5 @@
>  }
>  
> +NS_IMETHODIMP nsMsgProtocol::Open2(nsIInputStream **_retval)
> +{
> +  nsCOMPtr<nsIStreamListner> listener;

nsIStreamListner  will be changed to 
nsIStreamListener.

Comment 21

[Edmund Wong (:ewong)]

Attachment: proposed patch(v2)

Comment 22

[Edmund Wong (:ewong)]

Comment on attachment 8636367 [details] [diff] [review]
proposed patch(v2)

No.. wrong..  sorry for the bugspam.

Comment 23

[Hartmut Figge]

And now my build succeeds. SM-Trunk Linux x86_64

Comment 24

[Edmund Wong (:ewong)]

I'm not exactly sure how to approach this as I'm not familiar with this code.
While the 
From: http://mxr.mozilla.org/comm-central/source/mailnews/imap/src/nsImapService.cpp#453

440    if (NS_SUCCEEDED(rv) && aStreamListener)
441     {
442       nsCOMPtr<nsIChannel> aChannel;
443       nsCOMPtr<nsILoadGroup> aLoadGroup;
444       nsCOMPtr<nsIMsgMailNewsUrl> mailnewsUrl = do_QueryInterface(uri, &rv);
445       if (NS_SUCCEEDED(rv) && mailnewsUrl)
446         mailnewsUrl->GetLoadGroup(getter_AddRefs(aLoadGroup));
447 
448       rv = NewChannel(uri, getter_AddRefs(aChannel));
449       NS_ENSURE_SUCCESS(rv, rv);
450 
451       nsCOMPtr<nsISupports> aCtxt = do_QueryInterface(uri);
452       //  now try to open the channel passing in our display consumer as the listener
453       return aChannel->AsyncOpen(aStreamListener, aCtxt);
454     }
455   }

So as I understand it from the Firefox code, there's a security check
within the AsyncOpen2() code and then it calls AsyncOpen with the ctx as
nullptr. 

In the above case, what is the right approach for this? If I just blindly
replace the above with AsyncOpen2(), we'd lose the point of setting up the
aCtxt. 

There are a couple of instances of the above in nsImapService.cpp and
nsMsgQuote.cpp.

Comment 25

[Joshua Cranmer [:jcranmer]]

(In reply to Edmund Wong (:ewong) from comment #24)
> In the above case, what is the right approach for this? If I just blindly
> replace the above with AsyncOpen2(), we'd lose the point of setting up the
> aCtxt. 

For the time being, I would advocate just adding the AsyncOpen2/Open2 methods and not trying to switch to them.

Comment 26

[Edmund Wong (:ewong)]

(In reply to Joshua Cranmer [:jcranmer] from comment #25)
> (In reply to Edmund Wong (:ewong) from comment #24)
> > In the above case, what is the right approach for this? If I just blindly
> > replace the above with AsyncOpen2(), we'd lose the point of setting up the
> > aCtxt. 
> 
> For the time being, I would advocate just adding the AsyncOpen2/Open2
> methods and not trying to switch to them.

Thanks.

Comment 27

[Edmund Wong (:ewong)]

Attachment: proposed patch(v3)

Comment 28

[Ian Neal]

Comment on attachment 8636398 [details] [diff] [review]
proposed patch(v3)

>+++ b/mailnews/base/util/nsMsgProtocol.cpp
> }
Nit: missing empty line
>+NS_IMETHODIMP nsMsgProtocol::AsyncOpen2(nsIStreamListener *aListener)
>+{
>+    nsCOMPtr<nsIStreamListener> listener = aListener;
>+    nsresult rv = nsContentSecurityManager::doContentSecurityCheck(this, listener);
>+    NS_ENSURE_SUCCESS(rv, rv);
>+    return AsyncOpen(listener, nullptr);
>+}

>+++ b/mailnews/imap/src/nsImapProtocol.cpp
>@@ -8960,22 +8961,29 @@ NS_IMETHODIMP nsImapMockChannel::SetURI(
>           if (NS_SUCCEEDED(msgHdr->GetMessageSize(&messageSize)))
>             SetContentLength(messageSize);
>         }
>       }
>     }
>   }
>   return NS_OK;
> }
>-
Why remove this line?
> NS_IMETHODIMP nsImapMockChannel::Open(nsIInputStream **_retval)
> {
>   return NS_ImplementChannelOpen(this, _retval);
> }

rs=me

Comment 29

[Ian Neal]

a=me for CLOSED TREE too

Comment 30

[Edmund Wong (:ewong)]

(In reply to Ian Neal from comment #28)
> Comment on attachment 8636398 [details] [diff] [review]
> proposed patch(v3)
> 
> >+++ b/mailnews/base/util/nsMsgProtocol.cpp
> > }
> Nit: missing empty line

Fixed.

> >+NS_IMETHODIMP nsMsgProtocol::AsyncOpen2(nsIStreamListener *aListener)
> >+{
> >+    nsCOMPtr<nsIStreamListener> listener = aListener;
> >+    nsresult rv = nsContentSecurityManager::doContentSecurityCheck(this, listener);
> >+    NS_ENSURE_SUCCESS(rv, rv);
> >+    return AsyncOpen(listener, nullptr);
> >+}
> 
> >+++ b/mailnews/imap/src/nsImapProtocol.cpp
> >@@ -8960,22 +8961,29 @@ NS_IMETHODIMP nsImapMockChannel::SetURI(
> >           if (NS_SUCCEEDED(msgHdr->GetMessageSize(&messageSize)))
> >             SetContentLength(messageSize);
> >         }
> >       }
> >     }
> >   }
> >   return NS_OK;
> > }
> >-
> Why remove this line?

Sorry. Fixed.

Will update the patch and push it.

Comment 31

[Edmund Wong (:ewong)]

Attachment: patch for checkin

Comment 32

[Edmund Wong (:ewong)]

Comment on attachment 8636888 [details] [diff] [review]
patch for checkin

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/3903bf440cfd