1185725 - The update-status badge on #PanelUI-menu-button isn't visible anymore

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Brian Grinstead [:bgrins]]

After Bug 1029937, the markup for toolbarbutton-badges changed.  But there is still one instance of toolbarbutton-badge::after referenced in browser/themes/shared/customizableui/panelUIOverlay.inc.css: http://mxr.mozilla.org/mozilla-central/search?string=toolbarbutton-badge%3A%3Aafter.

This means that the green arrow shown when there is a pending update isn't visible.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1029937#c44.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: badge-osx.png

Moving the discussion from Bug 1029937 to here.  As per my review comment, there is an issue on osx with an unfocused window.

Here's a screenshot with the patch from Bug 1029937 applied in OSX showing an issue with the icon being clipped when the window is unfocused.  Looks like there is a 1px border applied to .toolbarbutton-badge:-moz-window-inactive from toolbarbuttons.css which causes the issue.  It might be simplest to just apply border: none to the #PanelUI-menu-button[update-status="succeeded"] > .toolbarbutton-badge-stack > .toolbarbutton-badge rule.

Comment 2

[[e-mail]]

(In reply to Brian Grinstead from comment #1)
> Looks like there is a 1px border applied to .toolbarbutton-badge:-moz-window-inactive

(Yeah, I did wonder about that at the time when writing the patch for bug 1029937, it seems odd to change the size of UI depending on whether the window is active or not.)

Comment 3

[[e-mail]]

Attachment: Revised patch

Comment 4

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f74712e20ab2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f74712e20ab2