118574 - JavaScript strict warnings in showbuilds.cgi

Status: VERIFIED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Alex Vincent [:WeirdAl]]

Warning: reference to undefined property document.layers
Source File: http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey
Line: 73

(clicking one link in guilty column, above strict warning repeated 13 times!)

Warning: reference to undefined property document.layers
Source File: http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey
Line: 104

(clicking one star link, above strict warning repeated 13 times)

Why are we using document.layers to detect for a Netscape 4 browser?
http://developer.netscape.com/evangelism/tools/practical-browser-sniffing/

See bug 81279 for indications why throwing strict warnings en masse is a Bad Thing.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20020106

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

The fact that it's repeated 13 times is bug 104549

Comment 2

[timeless]

Attachment: test for undefined

in isn't available in nc4 which makes detection so much fun.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 63925 [details] [diff] [review]
test for undefined

this'll do it.	r=caillon

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 63925 [details] [diff] [review]
test for undefined

Um, would you fix your quotes first actually?  :)  Then r=me

Comment 5

[timeless]

done :)

Comment 6

[Alex Vincent [:WeirdAl]]

Cool beans.  Thanks, guys.  Took me a moment in #mozillazine to see why you
didn't use the sniffer.