1186014 - [TSF] Rename nsTextStore to mozilla::widget::TSFTextStore

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that we should move nsTextStore from global namespace to mozilla::widget. Then, nsTextStore.h can be simpler.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Rename nsTextStore to mozilla::widget::TSFTextStore

Renaming widget/windows/nsTextStore.* -> widget/windows/TSFTextStore.*

nsTextStore -> mozilla::widget::TSFTextStore

I was thinking the new name should be TextStore. However, it's not clear what the file implements. Therefore, I think that it's better to add TSF prefix for TSF related classes like TSFStaticSink.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8637865 [details] [diff] [review]
Rename nsTextStore to mozilla::widget::TSFTextStore

Review of attachment 8637865 [details] [diff] [review]:
-----------------------------------------------------------------

nice clean code, thanks!

::: widget/windows/TSFTextStore.cpp
@@ +21,5 @@
>  #define TEXTATTRS_INIT_GUID
> +#include "TSFTextStore.h"
> +
> +namespace mozilla {
> +namespace widget {

great!

@@ +730,5 @@
>      *pprgInputScopes = pScope;
>      return S_OK;
>    }
>  
> +  STDMETHODIMP GetPhrase(BSTR **ppbstrPhrases, UINT* pcCount)

was this an 80 character limit change? This seems out of place to me this way. Not a big deal though.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> @@ +730,5 @@
>>      *pprgInputScopes = pScope;
>>      return S_OK;
>>    }
>>  
>> +  STDMETHODIMP GetPhrase(BSTR **ppbstrPhrases, UINT* pcCount)
> 
> was this an 80 character limit change? This seems out of place to me this way. Not a big deal though.

Yes. When I fix BSTR** style, I included the fix.

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8637865 [details] [diff] [review]
Rename nsTextStore to mozilla::widget::TSFTextStore

Review of attachment 8637865 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/TSFTextStore.cpp
@@ +1217,5 @@
>    return false;
>  }
>  
>  /******************************************************************/
> +/* TSFTextStore                                                    */

remove one space character.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/807550417c75cc76e2acb417861063c3fa720cbd
changeset:  807550417c75cc76e2acb417861063c3fa720cbd
user:       Masayuki Nakano <[e-mail]>
date:       Fri Jul 24 14:07:39 2015 +0900
description:
Bug 1186014 Rename nsTextStore to mozilla::widget::TSFTextStore r=jimm+m_kato

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/807550417c75