1186401 - Clean up zamboni mkt/webapps/query.py

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Mathieu Pillard [:mat]]

In zamboni, mkt/webapps/query.py contains IndexQuerySet, IndexQuery, IndexCompiler.

- IndexQuerySet appear to be useless nowadays, we use that class in webapps and versions but never actually use its methods (with_index() and fetch_missed()).
- IndexQuery and IndexCompiler are only used by the translations app, so we should probably move that code in mkt/translations/query.py

Comment 1

[Mathieu Pillard [:mat]]

Bumped into this again while implementing bug 1208099 because of the way IndexQuerySet and ManagerBase.get_queryset() are implemented. Doing that cleanup will unblock me without having to do weird hacks.

Comment 2

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/cd5b91972aa1c9a0b7782128df9f168aaa3d5cb5

QA:
- Please test the whole Marketplace extensively :) In particular, posting an app with translations and making sure those translations appear depending on the language set in the client, once the app is published.

Comment 3

[Victor Carciu]

Cannot test the bug right now because of https://bugzilla.mozilla.org/show_bug.cgi?id=1203489