1186448 - pdfjschildbootstrap.js is executed every time a browser is opened, and should only run once per child process

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

It looks like pdfjschildbootstrap.js is loaded in nsBrowserGlue.js into the window message manager, such that it is executed every time a browser is loaded.

I'm reasonably certain this should only run once per child process, and not once per browser.

Am I right on that, jimm?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Note that if we moved this to running only once per process as opposed to once per browser, this would eliminate a sync message that PdfjsContentUtils sends in order to figure out whether or not it's the default PDF handler. That'd be a nice result.

Comment 2

[Jim Mathies [:jimm]]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #0)
> It looks like pdfjschildbootstrap.js is loaded in nsBrowserGlue.js into the
> window message manager, such that it is executed every time a browser is
> loaded.
> 
> I'm reasonably certain this should only run once per child process, and not
> once per browser.
> 
> Am I right on that, jimm?

Yes I think so. The script needs to load into every process via a single call here, I'm guessing there's something for that?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Yeah, I believe billm added the ability to use "process scripts": 

https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Message_Manager/Process_scripts

vladan - can I assign this to your intern?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1186448 - pdfjschildbootstrap.js should only be executed once per child process. r?jimm

Bug 1186448 - pdfjschildbootstrap.js should only be executed once per child process. r?jimm

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8643275 [details]
MozReview Request: Bug 1186448 - pdfjschildbootstrap.js should only be executed once per child process. r?jimm

https://reviewboard.mozilla.org/r/15013/#review13531

I'd suggest pushing to try as there are some basic tests for pdfjs in browser chrome.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

url:        https://hg.mozilla.org/integration/fx-team/rev/670b14b5b033de46a55acfa8c985a116fefdffea
changeset:  670b14b5b033de46a55acfa8c985a116fefdffea
user:       Mike Conley <[e-mail]>
date:       Tue Aug 04 15:55:54 2015 -0400
description:
Bug 1186448 - pdfjschildbootstrap.js should only be executed once per child process. r=jimm

We were executing it once per tab, originally.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/670b14b5b033