Closed
Bug 1186845
Opened 9 years ago
Closed 9 years ago
On B2G, let MP4Decoder handle 3GPP files.
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: jhlin, Assigned: jhlin)
Details
Attachments
(1 file, 1 obsolete file)
1.57 KB,
patch
|
jhlin
:
review+
|
Details | Diff | Splinter Review |
Part of work to deprecate Media(Omx|Codec)Decoder per discussion with :bwu. Also make fixing bug 1159343 easier because 3GPP files (recorded by Camera app) and MP4 files currently use different decoder and both have seeking problem. :)
Assignee | ||
Comment 1•9 years ago
|
||
Returns true for 3GPP files in MP4Decoder::HandleMediaType() when Gonk PDM is available.
Attachment #8637803 -
Flags: review?(cpearce)
Comment 2•9 years ago
|
||
Comment on attachment 8637803 [details] [diff] [review] Let MP4Decoder handle 3GPP files on B2G. Review of attachment 8637803 [details] [diff] [review]: ----------------------------------------------------------------- I assume our demuxer and the Gonk PDM can handle 3GPP?
Attachment #8637803 -
Flags: review?(cpearce) → review+
Comment 3•9 years ago
|
||
(In reply to John Lin [:jolin][:jhlin] from comment #0) > Part of work to deprecate Media(Omx|Codec)Decoder per discussion with :bwu. Yeah! After syncing with cpearce via irc two weeks ago?, the goal is to use MediaFormatReader for all the formats if possible. So we should deprecate MediaOmxReader and MediaCodecReader.
Assignee | ||
Comment 4•9 years ago
|
||
Carry r+ from cpearce.
Attachment #8637803 -
Attachment is obsolete: true
Attachment #8648666 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b51fb316777
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1d3817f7fff6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•