1186893 - keyboard.is_keyboard_displayed is always returning true in current builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

Follow-up from bug 1186462.

See http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#442
Because inputwindow gets class called 'inactive' when it's not active anymore. Quite obvious that this check doesn't work.

I think we should check for like is done in dismiss():
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#343

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1186893 > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8637993 [details] [review]
[gaia] mwargers:1186893 > mozilla-b2g:master

In my opinion, I think only the input_window.is_displayed() part would be enough. 
I don't think the (int(input_window.location['y']) == expected_y) part is necessary, either.

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8637993 [details] [review]
[gaia] mwargers:1186893 > mozilla-b2g:master

r+ assuming the comments I made in the pull requests are non-issue.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8637993 [details] [review]
[gaia] mwargers:1186893 > mozilla-b2g:master

This refactor looks great!

Comment 5

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/c0c218fe20ff4d07a7dd8777ea7d6835c89d663b