1187137 - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are 27 occurrences of Enumerate() in these directories.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::Data() rather than nsBaseHashtable::Iterator::UserData(). (The latter should be used when replacing nsBaseHashtable::EnumerateRead()).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 5

[Michal Novotny [:michal]]

Comment on attachment 8682847 [details] [diff] [review]
(part 2) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Review of attachment 8682847 [details] [diff] [review]:
-----------------------------------------------------------------

Although this seems to be correct, I think it's hard to read. This iteration should be IMO rewritten like this:

iter = mCT.Iter();
while (mNumIdleConns... && !iter.Done()) {
  if (!ent->mIdleConns.Length()) {
    iter.Next();
    continue;
  }

  ...
}

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Updated as requested.

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b886c41710f8179818813068d2f5e9023a94cb29
Bug 1187137 (part 1) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=michal.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a009f9deeb03ea29a978aab94a2cd4f5a54957e
Bug 1187137 (part 2) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=michal.

https://hg.mozilla.org/integration/mozilla-inbound/rev/09e636bb2c9b63368e977082f3e4650656bdbee9
Bug 1187137 (part 3) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=michal.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b886c41710f8
https://hg.mozilla.org/mozilla-central/rev/6a009f9deeb0
https://hg.mozilla.org/mozilla-central/rev/09e636bb2c9b

Comment 9

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 10

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 11

[Nicholas Nethercote [inactive]]

Attachment: (part 6) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 12

[Nicholas Nethercote [inactive]]

Attachment: (part 7) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 13

[Nicholas Nethercote [inactive]]

Attachment: (part 8) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 14

[Nicholas Nethercote [inactive]]

Attachment: (part 9) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 15

[Nicholas Nethercote [inactive]]

Attachment: (part 10) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 16

[Nicholas Nethercote [inactive]]

Attachment: (part 11) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 17

[Nicholas Nethercote [inactive]]

Attachment: (part 12) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 18

[Nicholas Nethercote [inactive]]

Attachment: (part 13) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators

Comment 19

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76517f16771db1e293f2fc781eda6fba4d20f062
Bug 1187137 (part 4) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1335a833b756994c85da9548b9053c6d3cbbb85
Bug 1187137 (part 5) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/855f567e4f21230ce2fecd3022e5880d9bc87565
Bug 1187137 (part 6) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac21d6f878e6fdd69ec4140d1b63a94601524abe
Bug 1187137 (part 7) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76517f16771d
https://hg.mozilla.org/mozilla-central/rev/f1335a833b75
https://hg.mozilla.org/mozilla-central/rev/855f567e4f21
https://hg.mozilla.org/mozilla-central/rev/ac21d6f878e6

Comment 21

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfef4b5dc032f324af417a93fbf5291c5cb2540e
Bug 1187137 (part 8) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1ed2ffd03e963bdf30c1d0c7bdbae8049479eb
Bug 1187137 (part 9) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c67afd9ada68310b73fbb9c24b33b8888c3c4c1
Bug 1187137 (part 10) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/00f18a5aaa83f7b129a798e9d29249c664dab9aa
Bug 1187137 (part 11) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7212563735e403379ad73189536860e72aec342c
Bug 1187137 (part 12) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

https://hg.mozilla.org/integration/mozilla-inbound/rev/40fdba3c4cd4516a1ce313d41c40ef9b10484dbe
Bug 1187137 (part 13) - Replace nsBaseHashtable::Enumerate() calls in netwerk/protocol/ with iterators. r=valentin.

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dfef4b5dc032
https://hg.mozilla.org/mozilla-central/rev/7a1ed2ffd03e
https://hg.mozilla.org/mozilla-central/rev/3c67afd9ada6
https://hg.mozilla.org/mozilla-central/rev/00f18a5aaa83
https://hg.mozilla.org/mozilla-central/rev/7212563735e4
https://hg.mozilla.org/mozilla-central/rev/40fdba3c4cd4