1187142 - Replace nsBaseHashtable::Enumerate() calls in hal/ with iterators

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There is one occurrence of Enumerate() in this directory.

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::Data() rather than nsBaseHashtable::Iterator::UserData(). (The latter should be used when replacing nsBaseHashtable::EnumerateRead()).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Replace nsBaseHashtable::Enumerate() calls in hal/ with iterators

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8676021 [details] [diff] [review]
Replace nsBaseHashtable::Enumerate() calls in hal/ with iterators

Review of attachment 8676021 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: hal/HalWakeLock.cpp
@@ +133,5 @@
> +          NotifyWakeLockChange(WakeLockInfoFromLockCount(iter.Key(),
> +                                                         totalCount));
> +        }
> +
> +        if (totalCount.numLocks == 0) {

Yes! Much easier to read that !totalCount.numLocks

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f2acbbadd117438960fa1176ef5c067571372a3
Bug 1187142 - Replace nsBaseHashtable::Enumerate() calls in hal/ with iterators. r=dhylands.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f2acbbadd11