1187158 - Direct users to the Notification Center settings to disable badge of Dock Icon

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Javi Rueda :javirid]

That is one of the usual requests from users, the ability to disable the badge on the Dock icon on OS X.

Although we could implement a way to really stop showing it, OS X provides a standard way to do that same thing. In fact, if we really were to implement that setting, it woyld be not respected, as the badge is managed by the system itself.

A much better way is just to indicate the user where that setting must be changed, as it seems it is not very well known.

Comment 1

[Javi Rueda :javirid]

Attachment: Proposed caption

Hi Blake.

I have added a caption that directs users to the Notification panel on the System Preferences dialog box.

I am not an English as a first language speaker, so may be some rewording could be needed.

Could you please review it? Thank you.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8638289 [details]
Proposed caption

I think making it more of a sentence would fit in better with the rest of Thunderbird’s text.  How about “You can disable the badge on the Notifications pane of System Preferences.”?  (I also used the official Apple names for the various pieces, there, too. :)  And just to double-check, this text will only show up when you’re on a Mac, right?

(I'm setting it to ui-r-, not because I think it's bad, but just to indicate that I have some open questions.)

Comment 3

[Javi Rueda :javirid]

(In reply to Blake Winton (:bwinton) from comment #2)
> Comment on attachment 8638289 [details]
> Proposed caption
> 
> I think making it more of a sentence would fit in better with the rest of
> Thunderbird’s text.  How about “You can disable the badge on the
> Notifications pane of System Preferences.”?  (I also used the official Apple
> names for the various pieces, there, too. :)  And just to double-check, this
> text will only show up when you’re on a Mac, right?
> 

Ok. I am going to replace my proposed text with yours, as it is much better.

Also, about your question, both dockoptions.xul and corresponding .dtd is only added to the package, which user will download, when source code is being built for OS X: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=601263&attachment=8384723 as can be seen on jar.mn files.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Perfect!  Feel free to ui-r? me on the patch, and I'll try to give it a quick ui-r+.  :)

Comment 5

[Javi Rueda :javirid]

Attachment: Corrected caption

Comment 6

[Javi Rueda :javirid]

Attachment: bug-1187158.patch

Patch corresponding to the screenshoot (attachment 8638607 [details]).

Files modified had been previously reviewed by :standard8, so I am assuming he is the best guess here also.

Mark, could you take a look on this patch, please? Thank you.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8638609 [details] [diff] [review]
bug-1187158.patch

:)

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8638609 [details] [diff] [review]
bug-1187158.patch

Sorry, I'm not generally doing Thunderbird reviews these days.

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 8638609 [details] [diff] [review]
bug-1187158.patch

Review of attachment 8638609 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, Javi! r=mkmelin

Comment 10

[Javi Rueda :javirid]

Thank you for the review, Magnus.

Comment 11

[aleth [:aleth]]

url:        https://hg.mozilla.org/comm-central/rev/8160e3fc67ae54531c66265bc4872c002abfb7e9
changeset:  8160e3fc67ae54531c66265bc4872c002abfb7e9
user:       Javier Rueda <[e-mail]>
date:       Fri Jul 24 10:06:00 2015 +0200
description:
Bug 1187158 - Direct users to the Notification Center settings to disable badge of Dock Icon. r=mkmelin, ui-r=bwinton