Closed Bug 1187201 Opened 9 years ago Closed 9 years ago

Char16 wrapper for VS2015 doesn't work with external NS_ConvertUTF16toUTF8

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

patch
1.14 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
The Char16 pointer wrapper for VS2015 doesn't work with the NS_ConvertUTF16toUTF8 in external String API. It causes the following compile error:
> central/browser/components/shell/nsWindowsShellService.cpp(397): error C2440: '<function-style-cast>': cannot convert from 'LPCWSTR' to 'NS_ConvertUTF16toUTF8_external'
> central/browser/components/shell/nsWindowsShellService.cpp(397): note: Source or target has incomplete type
Attached patch patch — — Splinter Review 

        Attachment #8638348 -
        Flags: review?(nfroyd)

    
  
Assignee: nobody → quanxunzhen

        Attachment #8638348 -
        Flags: review?(nfroyd) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ecfe46601d7f
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox42:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

    
  
Depends on: 1188431

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: