1187301 - Drop |isPersisted| argument in TelemetrySend.jsm functions

Status: RESOLVED WONTFIX

(Toolkit :: Telemetry, defect, P4)

Description

[Alessio Placitelli [:Dexter]]

We could remove the "isPersisted" juggling and just always call remove*Ping() in TelemetrySend [1].
If it's not persisted, TelemetryStorage will just not do anything.

[1] - https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/toolkit/components/telemetry/TelemetrySend.jsm#l753

Comment 1

[Georg Fritzsche [:gfritzsche]]

We should be able to remove all the uses of |isPersisted| here:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcomponents%2Ftelemetry%2F+isPersisted&redirect=false&case=true

... as this check only needs to check for |success|:
https://dxr.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31/toolkit/components/telemetry/TelemetrySend.jsm#850

That cleans up & simplifies our code a little bit.

Comment 2

[aliyua7]

Hello i would like to work on this bug

Comment 3

[Georg Fritzsche [:gfritzsche]]

Hi - we had an active discussions about whether we can do this as proposed in comment 0 and comment 1.
Until we resolved that, i don't think this is a good mentored bug, sorry :)

The problem here is that the suggestion in comment 0 would mean that trying to constantly remove pings that don't exist would never show up properly as an error or warning.