Closed
Bug 1187339
Opened 9 years ago
Closed 9 years ago
Always duplicate-save new main pings as aborted-session pings
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
(Whiteboard: [unifiedTelemetry] [uplift4])
Attachments
(1 file, 1 obsolete file)
4.66 KB,
patch
|
gfritzsche
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Currently, when creating new daily or other pings, we only store their payloads as "aborted-session" pings when "aborted-session" is due per the 5min interval. This means that aborted-session can lag behind in regards to session-chaining and profileSubsessionCounter etc.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8639454 -
Flags: review?(alessio.placitelli)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8639454 [details] [diff] [review] Always duplicate-save new main pings as aborted-session pings Review of attachment 8639454 [details] [diff] [review]: ----------------------------------------------------------------- Looks great, r=me with the following addressed! ::: toolkit/components/telemetry/TelemetrySession.jsm @@ +1876,5 @@ > }, > > /** > * Gather and send a daily ping. > * @param {Boolean} [saveAsAborted=false] Also saves the payload as an aborted-session This comment needs to be updated. @@ +1890,5 @@ > addEnvironment: true, > }; > > let promise = TelemetryController.submitExternalPing(getPingType(payload), payload, options); > // If required, also save the payload as an aborted session. I think it would be nice to explain why we are always saving the daily ping as an aborted ping: what do you think?
Attachment #8639454 -
Flags: review?(alessio.placitelli) → review+
Assignee | ||
Updated•9 years ago
|
Whiteboard: [unifiedTelemetry] [uplift4]
https://hg.mozilla.org/mozilla-central/rev/daf25286f461
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8641667 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8639454 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
status-firefox39:
wontfix → ---
status-firefox41:
--- → affected
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8641667 [details] [diff] [review] Always duplicate-save new main pings as aborted-session pings Approval Request Comment [Feature/regressing bug #]: Telemetry Unification [User impact if declined]: This is a simple fix for when we generate backup data for detecting crashed session, which is important for crash analysis. It is part of a mostly fixup & diagnostic uplift batch for 41: http://bit.ly/1LYhA16 [Describe test coverage new/current, TreeHerder]: We have automated test-coverage, it baked on Nightly. [Risks and why]: We haven't seen anything crop up on Nightly here. This simplifies code to simply always store the backup, so risk seems low. [String/UUID change made/needed]: None.
Attachment #8641667 -
Flags: approval-mozilla-aurora?
Comment on attachment 8641667 [details] [diff] [review] Always duplicate-save new main pings as aborted-session pings [Triage Comment] Patch been in m-c since 7/28 and adds improvements to crash-analysis data. Let's uplift to Beta41.
Attachment #8641667 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/a0c7312b3872
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•