1187739 - Proxy handling for mozActionElements

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Lorien Hu (:lsocks)]

Attachment: action-p1

Comment 2

[Lorien Hu (:lsocks)]

Attachment: action p1 - {isTab, accessibilityArrayAttributeCount, hasPopup, Checked}

Comment 3

[Lorien Hu (:lsocks)]

Attachment: action p2 - click, value

Comment 4

[Lorien Hu (:lsocks)]

Attachment: action p2 - click, value

Comment 5

[Lorien Hu (:lsocks)]

Attachment: action p2 - click, value

Comment 6

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8639069 [details] [diff] [review]
action p1 - {isTab, accessibilityArrayAttributeCount, hasPopup, Checked}

> - (BOOL)isTab
> {
>-  AccessibleWrap* accWrap = [self getGeckoAccessible];
>-  return (accWrap && (accWrap->Role() == roles::PAGETAB));
>+  if (AccessibleWrap* accWrap = [self getGeckoAccessible])
>+    return (accWrap && (accWrap->Role() == roles::PAGETAB));

the accWrap check is redundant

>+
>+  if (ProxyAccessible* proxy = [self getProxyAccessible])
>+    return (proxy && (proxy->Role() == roles::PAGETAB));

same with proxy

> - (BOOL)hasPopup
> {
>-  AccessibleWrap* accWrap = [self getGeckoAccessible];
>-  return accWrap && (accWrap->NativeState() & mozilla::a11y::states::HASPOPUP);
>+  if (AccessibleWrap* accWrap = [self getGeckoAccessible])
>+    return accWrap->NativeState() & mozilla::a11y::states::HASPOPUP;

the mozilla::a11y is probably not needed

it seems strange NativeState() not State() is used but whatever

>   // By default this calls -[[mozAccessible children] count].
>   // Since we don't cache mChildren. This is faster.
>-  if ([attribute isEqualToString:NSAccessibilityChildrenAttribute])
>-    return [self getGeckoAccessible]->ChildCount() ? 1 : 0;
>+  if ([attribute isEqualToString:NSAccessibilityChildrenAttribute]) {
>+    if (accWrap)
>+      return accWrap->ChildCount() ? 1 : 0;
>+    else
>+      return proxy->ChildrenCount() ? 1 : 0;

no else after return

Comment 7

[Lorien Hu (:lsocks)]

Attachment: action p1 - {isTab, accessibilityArrayAttributeCount, hasPopup, Checked} with fixes

carry r=tbsaunde

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b0b584ce01f
https://hg.mozilla.org/integration/mozilla-inbound/rev/689c420edf65

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b0b584ce01f
https://hg.mozilla.org/mozilla-central/rev/689c420edf65