1188438 - Close the control center when the user clicks the tracking protection enable/disable button

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Matthew N. [:MattN]]

To align with the previous TP doorhanger UI and with other UI which changes content, we should close the panel since it doesn't seem like there's much else the user would want to do at the same time in the panel.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

I'll just pick this up because it's such an easy fix.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1188438-Close-the-control-center-when-the-user-c.patch

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8639923 [details] [diff] [review]
0001-Bug-1188438-Close-the-control-center-when-the-user-c.patch

Review of attachment 8639923 [details] [diff] [review]:
-----------------------------------------------------------------

A simple popup.state check in an existing test file would be good…

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Matthew N. [:MattN] from comment #3)
> A simple popup.state check in an existing test file would be good…

Good idea, added to browser/base/content/test/general/browser_trackingUI_5.js.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/130ef92fa5a7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/130ef92fa5a7

Comment 7

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 42
Build Id: 20150802030218
OS: Win 7 x64, Mac Os X 10.10, Ubuntu 12.04 x86