Closed
Bug 1188620
Opened 9 years ago
Closed 9 years ago
Use PersistentRooted for some misc JSObjects in markRuntime
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
3.30 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Now that PersistentRooted can root any object subclass and not just JSObject exactly, we can have it do the heavy lifting of rooting the SavedFrame pointer in JSRuntime.
Attachment #8640142 -
Flags: review?(paolo.mozmail)
Comment 1•9 years ago
|
||
Comment on attachment 8640142 [details] [diff] [review] use_persistent_rooted_for_async_activation-v0.diff That's cool! Redirecting final review to Nick who is a peer of the JS module.
Attachment #8640142 -
Flags: review?(paolo.mozmail) → review?(nfitzgerald)
Comment 2•9 years ago
|
||
Comment on attachment 8640142 [details] [diff] [review] use_persistent_rooted_for_async_activation-v0.diff Review of attachment 8640142 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8640142 -
Flags: review?(nfitzgerald) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d6dea3334b6c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 6•9 years ago
|
||
Reopened due to backout in comment #5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•9 years ago
|
status-firefox42:
fixed → ---
Target Milestone: mozilla42 → ---
Comment 7•9 years ago
|
||
Merge of backout: https://hg.mozilla.org/mozilla-central/rev/e601c8a36227 This will be in tomorrow's (7-Aug) nightly. Note that there's a nightly respin in progress now that will *NOT* contain these backouts.
Assignee | ||
Comment 8•9 years ago
|
||
This was not related to the crash, relanding.
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/17bfcce2b7d0
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•