1188834 - Compacting GC happens too often

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

Currently we run trigger a compacting GC when the user had been inactive for 20 seconds.  This results in a lot of compacting GCs and probably is causing some of the reports of long GC pauses occurring.

We should make this happen only after the user has been inactive for 5 minutes (except on nightly, to improve test coverage).

We should also make this a pref so it can be changed easily.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: less-frequent-compaction

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

Should we land this also on branches?

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Should we land this also on branches?

Yes, that's the plan.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60b5a53aeb8f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60b5a53aeb8f

Comment 6

[Jon Coppeard (:jonco)]

Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

Approval Request Comment
[Feature/regressing bug #]: Bug 1130439
[User impact if declined]: Possible long GC pauses.
[Describe test coverage new/current, TreeHerder]: On central for 4 days.
[Risks and why]: Low.
[String/UUID change made/needed]: None.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8640549 [details] [diff] [review]
less-frequent-compaction

The next beta of 40 will be the RC. So, this is too late to change anything wrt the gc. This will have to ride the train from 41.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47c89dde72d9