1188880 - Ship directory picking and directory drag and drop

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

Bug 1164310 implemented MS's proposal to support directory picking and directory drag and drop. The "Unofficial Draft" spec is very much a work in progress though and subject to change. Currently our implementation is behind the dom.input.dirpicker pref (enabled only in Nightly). This bug will track any issues that need to be resolved before the pref can be flipped to true for release.

Comment 1

[Jonathan Watt [:jwatt]]

We should consider pushing for and implementing bug 1173320 too.

Comment 2

[Loic]

Do you have a demo page (with a server side) to test Directory Upload?

Comment 3

[vulcain]

(In reply to Loic from comment #2)
> Do you have a demo page (with a server side) to test Directory Upload?

https://jwatt.org/blog/2015/09/14/directory-picking-and-drag-and-drop give this links https://jwatt.org/tmp/directory.html

Comment 4

[Daniel Kahn Gillmor]

When a user selects a directory, are they aware of the potentially sensitive contents of the directory?  For example, if the user selects ~/.config , should the browser really send out all application configuration data?  What about ~/.ssh or ~/.gpg (i.e. the recent targets of the pdf.js vulnerability)?

uploading arbitrary files is risky.  recursively uploading entire directories seems far riskier.  There is no security analysis at https://wicg.github.io/directory-upload/proposal.html .  Has anyone done one?

Comment 5

[Mats Palmgren (inactive)]

Daniel, that is being discussed in bug 907707.

Comment 6

[Karl Dubost💡 :karlcow]

webcompat issue related to this.

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I think we'll want some manual testing before releasing this (after implementation is complete), so setting the qe-verify+ flag.

Test suggestions/scenarios are appreciated.

Comment 10

[Bogdan Maris, Desktop QA]

We ran into this using Dropbox in the process of signing off Firefox 54 beta 13 build (users can't upload folders containing files, also reproducible in latest Nightly 55).

Is there any plan to fix this soon?

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

We shipped file/directory dnd last autumn, FF50 (bug 1288683).
There was one dropbox specific issue, bug 1293949 but that was fixed.
So sounds like there is possible a regression. 
There was recently bug 1369014, but that should be Nightly only.

So, please file a new bug.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

As of now, this bug is wontfix. We shipped different API, https://wicg.github.io/entries-api/

Comment 13

[Emil Ghitta, QA [:emilghitta]]

Hi Olli!

As per comment 11 , we have logged a new bug for this issue (bug 1371606).