1188905 - KidFox: Restricted profiles - Prevent clearing history

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

We do not want the restricted user to clear the history (if denied by the device owner).

We already have bugs in place for removing the clear options from settings (bug 1125979, bug 1125980) but there are at least these additional places:

* "Clear browsing history" button at the bottom of the History panel
* "Remove" context menu item when long pressing an entry in the History panel

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1188905-clear-history.patch

Comment 2

[:Margaret Leibovic]

Comment on attachment 8640585 [details] [diff] [review]
1188905-clear-history.patch

Review of attachment 8640585 [details] [diff] [review]:
-----------------------------------------------------------------

I was going to ask a question about removing items form the recent tabs panel, but then I noticed we don't even have that capability! Maybe we should file a bug about that (totally out of scope from this issue :)

::: mobile/android/base/home/HistoryPanel.java
@@ +41,5 @@
>  import android.text.style.StyleSpan;
>  import android.text.style.UnderlineSpan;
>  import android.util.Log;
>  import android.util.SparseArray;
> +import android.view.*;

Nit: Don't use global imports.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1188905-clear-history-v2.patch

Updated patch addressing the review comments.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

url:        https://hg.mozilla.org/integration/fx-team/rev/12855aeba4b75686e8772086994340a8cacae2a7
changeset:  12855aeba4b75686e8772086994340a8cacae2a7
user:       Sebastian Kaspari <[e-mail]>
date:       Fri Jul 31 09:59:01 2015 +0200
description:
Bug 1188905 - Restricted profiles: Prevent clearing history. r=margaret

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/12855aeba4b7

Comment 6

[Catalin Suciu [:csuciu]]

Verified on Nightly and Aurora that "Clear browsing history" button from the history panel and "Remove" context menu item are not displayed in a restricted profile if "Disable 'Clear browsing history' option is enabled