1188965 - Instantbird build bustages from Bug 1138063 and Bug 1186782

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: Fix

Two separate bustages.

rs=aleth

Comment 1

[aleth [:aleth]]

Comment on attachment 8640588 [details] [diff] [review]
Fix

Review of attachment 8640588 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/Makefile.in
@@ +5,5 @@
>  
> +FILES := \
> +	install.rdf.in \
> +	$(NULL)
> +FILES_PATH = $(FINAL_TARGET)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}

The key change here is s/:=/=. Everything else shouldn't matter.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Fix v2

Comment 3

[aleth [:aleth]]

Comment on attachment 8640620 [details] [diff] [review]
Fix v2

Review of attachment 8640620 [details] [diff] [review]:
-----------------------------------------------------------------

(For future reference, = is expanded when the variable is used, := when it's declared.)

Comment 4

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/71156eb5be91

Comment 5

[Ian Neal]

Sorry, forgot how filter in an if worked :(

Comment 6

[Patrick Cloke [:clokep]]

(In reply to Ian Neal from comment #5)
> Sorry, forgot how filter in an if worked :(

Not a problem! Thanks for fixing that in the first place. :)