1188970 - WebRTC log file is not created on Windows when the TMP env var is set and the default log file name is used

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Paul Kerr [:pkerr]]

This bug occurs on Windows platforms. When the WebRTC trace log is started by using the "Start Debug Mode" button on the about:webrtc page, and there is no webrtc log file specified using either the WEBRTC_TRACE_FILE environment variable or by setting the media.webrtc.debug.log_file pref, and the TMP environment variable is set then a path with a final forward slash ('/') instead of a backslash ('\') is constructed. Creating this file will fail on a Windows system. A Windows appropriate path separator needs to be used in order for fix this issue.

A work-around for this issue is to set a webrtc log file path using the media.webrtc.debug.log_file pref with a valid Windows path. After that has been set, a log file can be generated by using the 'Start Debug Mode' button.

Comment 1

[Paul Kerr [:pkerr]]

Attachment: WIP

Switch to using nsDirectoryService and nsIFile to generate OS specific paths

Comment 2

[Paul Kerr [:pkerr]]

Attachment: Fix usage of forward slash in constructing webrtc trace file path

Replaced the chain of logic that attempted to determine the location of the temporary
directory with a call to nsDirectoryService.
Use nsIFile object to append file name to path in an OS independent manner.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fa6cc610bd4

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2fa6cc610bd4