118903 - CFG Activation broken on latest trunk builds

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect)

Description

[Rodney Velasco]

Customized CFG will not load if activated in the all.js file.  Problem started
on the December 21, 2001 night builds.  Critical bug that affects AutoConfig and
preference locking.

Steps to Reproduce:
1. Download attached mozilla.cfg file to computer, download and name the file to
mozilla.cfg.

*hashed file that contains the following preferences*
lockPref("general.startup.browser", true ); /* Navigator */
lockPref("general.startup.mail", true); /* Mail */

2. Place mozilla.cfg file in the program directory containing the mozilla
executable (for mac place in the Essential Files Folder)
3. Add these lines to your all.js file located in the bin\defaults\pref directory.

pref("general.config.filename", "mozilla.cfg");
pref("general.config.vendor", "mozilla");

4. save all.js file and start Mozilla

Expected Result:
Mozilla should startup with Both the browser and mail client.  
Open General Prefences panel choose the 'Appearance' Category, in the Mozilla
should start up field:

1) Navigator checkbox should be checked and greyed out.  User should not be able
to modify checkbox.
2) Mail checkbox should be checked and greyed out.  User should not be able to
modify checkbox.

Actual result:
Browser starts up mail doesn't.  Both fields in preference panels can be
modified by user even though I specified a lockPref() for both preferences.

Might be a regression of bug 89137.

Comment 1

[Rodney Velasco]

Attachment: CFG file containing lockPref() functions to start browser and mail client.

Comment 2

[Rodney Velasco]

adding nsbeta1 keyword, very bad bug for us Customization Folks that require CFG
activation and AutoConfig for our testing.

Comment 3

[tao]

Hi, Rodney:

Is this a QA blocker for us? My impression is that QA couldn't test
auto-config-ed features at all with the recen build?

Hi, Brian/Jud: any chance we treat this as a p0? Is there an ETA on this?

-thx

Comment 4

[Brian Nesse (gone)]

Attachment: Proposed patch.

There are 2 problems here. First, the windows build system apparently changed
out from under the patch in bug 89137 while it was waiting to land. Second,
none of the autoconfig stuff was ever added to the installer packages so
autoconfig only works in a debug build.

Comment 5

[Brian Nesse (gone)]

I have also added the appropriate bits to the static build packages. The only 
thing I don't know for certain here is if the autoconfig module is built as part 
of the static build process.

Adding some folks I hope have some packaging knowledge to the cc list. Alec, JJ, 
Simon, can you guys r/sr these changes in attachment 64192 [details] [diff] [review] please?

Comment 6

[tao]

Great. 

Brian - thanks for the quick response.
QA - would you notify Yumi to deliver a build when the patches checked in.

thx

Comment 7

[Rodney Velasco]

Tao,yes this is a blocker for QA. No way to test autoconfig and pref locking of
new preferences added to the trunk.  

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 64192 [details] [diff] [review]
Proposed patch.

sr=sfraser

Comment 9

[Alec Flett]

Comment on attachment 64192 [details] [diff] [review]
Proposed patch.

sr=alecf

Comment 10

[Brian Nesse (gone)]

Fix checked in.

Comment 11

[Rodney Velasco]

Tested CFG activation on

Linux: 2002012208 trunk
Win2K: 2002012203 trunk
Mac OSX: 2002012208 trunk

Marking bug verified.