Closed Bug 1189337 Opened 9 years ago Closed 9 years ago

Remove footer + Sign Out button on settings page

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Version:
Avenir
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: chuck, Assigned: shahbaz17, Mentored)

References

Details

(Whiteboard: [good first bug]) 

      No description provided.
Blocks: 1189774
i need to work on this bug
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Thanks, Assigning you to the bug.
Assignee: nobody → shahbazalam17feb
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Status: NEW → ASSIGNED
Points: --- → 1
Hi David..  i am new to this..  what does points - - 1 mean..  and what shall i do next
Points are units of relative estimation measurement. The tracker bug that this bug blocks marks it as one complete project. We divide the work into iterations of time based on the total point score that we determine can fit into each iteration.

It doesn't change this bug, it just should've been entered when the bug was created.
Priority: -- → P1
Shahbaz, You need to recheck your code as the PR failed to pass travis.
Flags: needinfo?(shahbazalam17feb)
Do i need to remove footer as well as signout option from settings page?
Flags: needinfo?(shahbazalam17feb) → needinfo?(trishul.goel)
Whiteboard: [good first bug?]
Flags: needinfo?(trishul.goel)
Priority: P1 → P2
Mentor: trishul.goel
Whiteboard: [good first bug?] → [good first bug]
Hey Shahbaz have you tried suggestion commented on PR?
Flags: needinfo?(shahbazalam17feb)
Any progress on this? If this is still unchanged in two weeks, we'll unassign it.
Why i am getting these errors https://www.dropbox.com/s/wxe7in1a450v6hg/Screenshot%20from%202015-11-09%2023%3A30%3A28.png?dl=0 

Can anyone help in this ?
Flags: needinfo?(vaishnav.rd)
Flags: needinfo?(trishul.goel)
Flags: needinfo?(shahbazalam17feb)
Hi David, can you please help shahbaz here?
Flags: needinfo?(vaishnav.rd) → needinfo?(ddurst)
Hi David can you help Shahbaz with the travis checks?
Flags: needinfo?(trishul.goel)
I don't know that I can solve that. It looks like the first failure is related to the endpoint test, but someone more knowledgeable than I should speak to that.

:shahbaz17 -- are you able to see the travis failure details? They can point you to which particular tests are failing. It could be the test is no longer accurate; if it should be accurate then it will identify the error.
Flags: needinfo?(shahbazalam17feb)
This bug is now resolved.Pull request successfully merged and closed https://github.com/mozilla/fireplace/pull/1558
Flags: needinfo?(trishul.goel)
PR merged. Thanks Shahbaz.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(trishul.goel)
Flags: needinfo?(shahbazalam17feb)
Flags: needinfo?(ddurst)
Resolution: --- → FIXED
Hi Trishul, if you can add this here that would be great! https://wiki.mozilla.org/Marketplace/Contributing/Recognition
Verified as fixed in FF46(Win7, Android 4.2.1) and FFOS 2.6 (Flame)
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.