1189493 - remove "Fennec" product from socorro (not "FennecAndroid")

Status: RESOLVED WONTFIX

(Socorro :: Webapp, task, P3)

Description

[Lonnen :lonnen]

Let's get the old Fennec product out of Socorro. This is not to be confused with FennecAndroid, which is still there and useful.

Let's purge any one off weirdness we have for supporting it and accelerate the end date on the existing products to be ::now

Comment 1

[Robert Kaiser]

Yes please. I think the only thing that could be a bit harder here than with MetroFirefox is that I think we originally had been copying over versions from Fennec to FennecAndroid. But we really should clean this all up anyhow.

Comment 2

[Peter Bengtsson [:peterbe]]

The only place I've found where it does some sort of stored procedure to do with Fennec is here:
https://github.com/mozilla/socorro/blob/7f28d41daba11517d38b066dc87c93b20b1ba793/socorro/external/postgresql/raw_sql/procs/update_product_versions.sql#L98-L126

It clones each release with a product name called "Fennec" into "WebappRuntimeMobile". 
We can kill that and there'd be an implicit effect of killing two birds with one stone. 

In terms of getting rid of it from the drop-down, I'm guessing we just need to sunset every product_version where the product_name is Fennec (not FennecAndroid).

Is that correct Kairo?

Comment 3

[Robert Kaiser]

From all I know, we want to keep WebappRuntimeMobile around, but it should clone from FennecAndroid, not from Fennec, I guess we made a mistake when we set that up originally.

Comment 5

[Robert Kaiser]

(In reply to Peter Bengtsson [:peterbe] from comment #2)
> The only place I've found where it does some sort of stored procedure to do
> with Fennec is here

I also get the impression that somehow the FTP scraper might be feeding new versions to Fennec - it should only feed new ones to FennecAndroid (and get those copied to WebappRuntimeMobile).

Comment 6

[Peter Bengtsson [:peterbe]]

(In reply to Robert Kaiser (:[e-mail]) from comment #3)
> From all I know, we want to keep WebappRuntimeMobile around, but it should
> clone from FennecAndroid, not from Fennec, I guess we made a mistake when we
> set that up originally.

Not only is it not called "Fennec" in releases, it's not even called "FennecAndroid" :)

breakpad=> select product_name, count(product_name) as c from releases_raw group by product_name order by c desc limit 100;
 product_name |   c
--------------+-------
 firefox      | 58360
 mobile       | 16534
 thunderbird  | 16058
 b2g          | 12528
 seamonkey    |  7749
 camino       |     1
(6 rows)

Comment 7

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3137

Comment 8

[Robert Kaiser]

Hmm, your select statement from comment #6 talks about releases_raw but the SQL in your patch about releases_recent - are those different tables? Are they using the same or different product names? (Note that we rewrite from "mobile" to "Fennec"/"FennecAndroid" when processing releases_raw AFAIK)

Comment 9

[Robert Kaiser]

The "mobile" name should be confined to FTP scraping only, outside of FTP it always should be something that includes "Fennec" in the name.

Comment 10

[Peter Bengtsson [:peterbe]]

Kairo, `releases_recent` is a temp table built from `releases_raw`. 
`releases_raw` is built from the ftpscraper. If you look at the `product_name` column in `releases_raw` you'll see it's called "mobile". (Terrible name by the way!!)

Comment 11

[Robert Kaiser]

(In reply to Peter Bengtsson [:peterbe] from comment #10)
> (Terrible name by the way!!)

True, coming from a lot of history in the way the product was created that nowadays is Android-specific Fennec. That "mobile" is just a directory name on FTP/archive.m.o and should not be used anywhere else, hopefully.

Comment 12

[Robert Kaiser]

(In reply to Peter Bengtsson [:peterbe] from comment #10)
> Kairo, `releases_recent` is a temp table built from `releases_raw`. 

Before the transformations of product names etc. or after them? (I know, this is messy.)

Comment 13

[Robert Kaiser]

(In reply to Robert Kaiser (:[e-mail]) from comment #3)
> From all I know, we want to keep WebappRuntimeMobile around, but it should
> clone from FennecAndroid, not from Fennec, I guess we made a mistake when we
> set that up originally.

OK, this changed recently as I just heard, the webapp runtimes are deprecated, we can remove all the copying we have, both to WebbappRuntimeMobile and (from Firefox) to WebappRuntime.

Comment 14

[Peter Bengtsson [:peterbe]]

I tried several times and could never figure out where the Fennec production versions are coming from. There's some musky old stored procedure at play somewhere. What the ftpscraper pulls down is "mobile" and that goes into release_raw or something and then some stored procedure converts that into rows in product_versions. Somewhere there it makes the "conversion" from calling it "mobile" to calling it "FennecAndroid" (and "Fennec"). I could never find and control that piece of dark code.

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

Could we move this bug forward? Would it be make it easier to reduce the scope of this bug to not expose the Fennec choice in the UI? Thanks

Comment 16

[Pascal Chevrel:pascalc (PTO until April 26)]

Chris, could we do something about this bug? Thanks

Comment 17

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pascal: How important is it that we remove the menu item and/or move this bug forward? Is it high priority and affecting your work?

Comment 18

[Pascal Chevrel:pascalc (PTO until April 26)]

It is affecting my work in that I am a new user of Socorro and wasted like 30mn yesterday trying to understand why searching for Fennec crashes didn't work, having part of the UI broken (and the brokenness not being documented) makes the learning harder than it should.

Comment 19

[Will Kahn-Greene [:willkg] ET needinfo? me]

That makes sense.

Comment 20

[Will Kahn-Greene [:willkg] ET needinfo? me]

One of the issues we hit last last year was that the way Socorro processor handles incoming crashes for Fennec is that it changes the product_name to FennecAndroid if the app id matches a certain app id. However, Fenix was also sending that app id as were all the GeckoView products at the time. So I'm not thrilled by how crash reports come to be "FennecAndroid" in Socorro.

Looking at the data in Telemetry, it uses "Fennec" as the product name--not "FennecAndroid".

I'm in the process of identifying "weird discrepancies" between Socorro and Telemetry and routing them out. I think this is one of them. Instead of eliminating Fennec (for which we still get crash reports somehow), I'd rather undo the code that converts Fennec to FennecAndroid. That get us more in line with what's in Telemetry and it's the least surprising thing.

Given that, I'm going to WONTFIX this in favor of bug #1689027.