1189497 - Assets on Remote Tabs panel display soft

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Robin Andersen [:tecgirl]]

Attachment: device-type-assets.png

The device-type icons on the Remote Tabs panel are displaying soft. See side-by-side comparison with the Send Tab list—so one can assume it's not the assets.

Comment 1

[Karim Benhmida [:karim]]

Already working on this. The assets are good, the problem was in the code. PR on its way.

Comment 2

[Karim Benhmida [:karim]]

Robin, can you make 36 × 24 assets for deviceTypeDesktop and deviceTypeMobile. We currently have 36 x 25, and the image view that displays the icons has a 24 points height, so the assets are slightly resized which is why they look soft.

Comment 3

[Robin Andersen [:tecgirl]]

:karim will this change how the display on the Send Tab list?

Comment 4

[Karim Benhmida [:karim]]

No it won't.

Comment 5

[Richard Newman [:rnewman]]

Karim, does this need new assets? Comment 1 and Comment 2 disagree.

Comment 6

[Karim Benhmida [:karim]]

I can do a workaround to display the current assets correctly with code (basically resizing the UIImageView to avoid the small image stretch that makes the icons look soft), but I think its better to have new assets with the dimensions specified in Comment 2

Comment 7

[Robin Andersen [:tecgirl]]

Attachment: deviceTypes.zip

give these a whirl.

Comment 8

[Robin Andersen [:tecgirl]]

Attachment: deviceTypeDesktop-replacements.zip

try these.

Comment 9

[Richard Newman [:rnewman]]

Status update, Karim?

Comment 10

[Karim Benhmida [:karim]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/890

Comment 11

[Robin Andersen [:tecgirl]]

Comment on attachment 8645826 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/890

Looks good!

Comment 12

[Karim Benhmida [:karim]]

Merged PR: https://github.com/mozilla/firefox-ios/commit/a82509ff70bf3425806cb6bc4aa93fedc1a69792