Closed
Bug 1189647
Opened 9 years ago
Closed 9 years ago
Rename synchronize to unsafeSynchronize to encourage callers to think twice
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 2 obsolete files)
|
12.69 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8641558 -
Flags: review?(ttromey)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8641558 -
Attachment is obsolete: true
Attachment #8641558 -
Flags: review?(ttromey)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8641573 [details] [diff] [review] Rename synchronize to unsafeSynchronize to encourage callers to think twice Last version did not update tests that called synchronize.
Attachment #8641573 -
Flags: review?(ttromey)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8641573 -
Attachment is obsolete: true
Attachment #8641573 -
Flags: review?(ttromey)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8641770 [details] [diff] [review] Rename synchronize to unsafeSynchronize to encourage callers to think twice https://treeherder.mozilla.org/#/jobs?repo=try&revision=7735f0307c90
Attachment #8641770 -
Flags: review?(jsantell)
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8641770 [details] [diff] [review] Rename synchronize to unsafeSynchronize to encourage callers to think twice Review of attachment 8641770 [details] [diff] [review]: ----------------------------------------------------------------- Maybe it's obvious for those working in this area, but maybe a mention in the unsafeSynchronize function comments why this is unsafe, and the preferred/more safe way to do this, or what the exceptions are for why one should call this in the first place
Attachment #8641770 -
Flags: review?(jsantell) → review+
|
||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d4446e517b3a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•