Closed Bug 1189761 Opened 9 years ago Closed 8 years ago

Clean up Read All Reviews page

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Avenir
defect

Tracking

(Not tracked)

RESOLVED FIXED
2016-02-09

People

(Reporter: chuck, Assigned: spasovski)

References

Details

- Use hub/spoke header
- Add app name
- Move sign in button to be between review summary and list of reviews
- Move date to between review and action link
Blocks: 1189774
Points: --- → 2
Priority: -- → P1
Priority: P1 → P2
https://github.com/mozilla/fireplace/commit/4523258
Assignee: nobody → dspasovski
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2016-02-09
(In reply to Chuck Harmston [:chuck] from comment #0)
> - Use hub/spoke header
> - Add app name
> - Move sign in button to be between review summary and list of reviews
> - Move date to between review and action link

Everything looks good except the second thing. The app name is not displayed in Read All Reviews page. Where should the app name be displayed?
Please view this screencast: http://screencast.com/t/hJACVBsjTn
Flags: needinfo?(dspasovski)
The UI spec wanted it to be as "23 reviews for {App Name}". The reviews API endpoint doesn't provide this info but more importantly we don't have a good way to get this info in an l10n friendly format without hitting the same XSS issue that was related to the "back to {App Name}" bug.

I don't think it's a major issue to ignore that part of the requirement but if others feel strongly we could look at moving the app name in another location.
Flags: needinfo?(dspasovski)
You need to log in before you can comment on or make changes to this bug.