1189842 - Change sync post-login page (about:accounts) to instead direct to account:preferences#sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Comment 1

[Ryan Feeley [:rfeeley]]

With in-content preferences launching in release, and account:preferences#sync getting a small makeover, it makes sense that the sync experiences link to account:preferences#sync instead of about:accounts.

After users log in to sync, we should open account:preferences#sync instead of about:accounts.

Comment 2

[Edouard Oger [:eoger]]

Attachment: bug-1189842.patch

Ryan: Do you want us to close the about:accounts tab when we open the about:preferences#sync tab?

Mark: If Ryan answers yes to the above question, I might need directions on how to make the "Test the remote commands" test work in browser_aboutAccounts.js when we close the about:accounts window.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8643311 [details] [diff] [review]
bug-1189842.patch

Review of attachment 8643311 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks fine but I'm wondering if the user may get a little confused by the magic tabs switching that's going on. I think we should make a try build for rfeeley to sign off on the actual UX in-case it differs from his perceived UX.

::: browser/base/content/test/general/browser_aboutAccounts.js
@@ +38,5 @@
>  {
>    desc: "Test the remote commands",
>    teardown: function* () {
>      gBrowser.removeCurrentTab();
> +    gBrowser.removeCurrentTab();

we should add a comment here saying why we are nuking 2 tabs.

Comment 4

[Edouard Oger [:eoger]]

> [11:54:11]  <rfeeley>	the build is great
> [11:54:16]  <rfeeley>	works as designed!

It was a build using patched from both bug 1189842 and bug 1152385.

Comment 5

[Edouard Oger [:eoger]]

Attachment: bug-1189842.patch

Updated and rebased.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/92cb84b00e00

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for OSX about:accounts leaks.
https://treeherder.mozilla.org/logviewer.html#?job_id=4236162&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/f989f11f65a3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

And Windows

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Tweaked the test as the sync prefs pane leaks in tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d911267cf30

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9a5f3dd7d1c0

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9a5f3dd7d1c0

Comment 12

[Ryan Feeley [:rfeeley]]

The "Account connected" screen has been deprecated. After successful sign-in, please transition the user to about:preferences#sync instead opening it in a new tab (poor language choice on my fault), and "Account connected". I'll be filing a bug with this and other improvements.

Comment 13

[Mark Hammond [:markh] [:mhammond]]

(In reply to Ryan Feeley [:rfeeley] from comment #12)
> The "Account connected" screen has been deprecated. After successful
> sign-in, please transition the user to about:preferences#sync instead
> opening it in a new tab (poor language choice on my fault), and "Account
> connected". I'll be filing a bug with this and other improvements.

Ryan, I'm not sure what you are asking for here. What happens now is:

* User is on about:preferences#sync and does signup.
* about:accounts is opened in a new tab - so we have 2 relevant tabs open.
* After signup completes we switch back to the existing about:preferences tab.
* about:accounts remains open as a "background" tab showing the "Account Connected" page.

So after the process we *are* back on about:preferences#sync, but about:accounts does remain open.  Are you asking for that new about:accounts tab to be automatically closed after the process completes?  Note we probably do not want to transition the about:accounts tab to about:preferences#sync, as that would leave the user with two about:preferences tabs open.

Either way, can you please open a new bug and CC me?

Comment 14

[Ryan Feeley [:rfeeley]]

In step two you say "about:accounts is opened in a new tab". I think this is no longer the case. Nothing should close. We just just try to make sure the user lands in the preferences (because it helps them understand what sync does and the UI is right there).

Comment 15

[Mark Hammond [:markh] [:mhammond]]

(In reply to Ryan Feeley [:rfeeley] from comment #14)
> In step two you say "about:accounts is opened in a new tab". I think this is
> no longer the case. Nothing should close. We just just try to make sure the
> user lands in the preferences (because it helps them understand what sync
> does and the UI is right there).

Yep, that's (obviously) true, so I think we are all good.