119047 - 4.x Ja vCard is displayed garbled.

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

*****Observed with 01/09 trunk build******

The Japanese vCard sent with a 4.x mail is displayed garbled.

Steps to reproduce:
1. Send a mail with Japanese vCard from 4.x.
2. View the mail with the latest mozilla build.

Tha Japanese vCard is garbled.
I'll attach a testing mail.

Comment 1

[ji]

Attachment: A testing mail.

Comment 2

[nhottanscp]

Because 4.x generated vCard has a wrong charset specification, it says
iso-2022-jp but actual data is Shift_JIS. So we have a fallback code for the
conversion, if iso-2022-jp fails then we use Shift_JIS. It used to work, but I
debugged today and no conversion error is returned even if we feed Shift_JIS
data to ISO-2022-JP converter. It might be some change for the converter
recently, cc to ftang.

Comment 3

[nhottanscp]

It doesn't seem to be related to the converter change.
I can reproduce it with 11/22 build, 11/09 build does not have the problem.

Comment 4

[ji]

Nominating for nsbeta1.

Comment 5

[Frank Tang]

nsbeta1+ per triage meeting 

Comment 6

[nhottanscp]

In nsISO2022JPToUnicodeV2::Convert, it does not goto the error immediately.

http://lxr.mozilla.org/s
eamonkey/source/intl/uconv/ucvja/nsJapaneseToUnicode.cpp#556

556 } else if(*src & 0x80) {
557 *dest++ = 0xFFFD;
558 if(dest >= destEnd)
559 goto error1;
560 } else {


then later in the following code,

938 error1:
939 *aDestLen = dest-aDest;
940 src++;
941 if ((mState == 0) && (src == srcEnd)) {
942 return NS_OK;
943 }
944 *aSrcLen = src - (const unsigned char*)aSrc;
945 return NS_OK_UDEC_MOREOUTPUT;
946 }

the error is not always set. I think this causes the vCard not shown correctly,
because we depends on the error code to re-try conversion with other charset.

Reassign to ftang.

Comment 7

[Frank Tang]

accept

Comment 8

[Frank Tang]

Attachment: patch v1 to return error code when we hit 8 bits data in ISO2022 converter

Comment 9

[Frank Tang]

Attachment: v2 of the patch. handle error for all the cases in ISO2022JP converter

Comment 10

[nhottanscp]

Comment on attachment 70351 [details] [diff] [review]
v2 of the patch. handle error for all the cases in ISO2022JP converter

r=nhotta

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 70351 [details] [diff] [review]
v2 of the patch. handle error for all the cases in ISO2022JP converter

sr=jst

Comment 12

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 13

[Frank Tang]

fixed and checked in.

Comment 14

[ji]

Verified as fixed with 03/20 builds.