1190476 - set Comment field in GPG email to the URL of the bug

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:Atoll]

When sending bugmail, we plaintext reference the bug # in the email plaintext headers. It would be helpful to have a direct link to the bug in the plaintext email as well (when viewing GPG emails on non-GPG clients).

Could you please activate the 'comment' attribute in the Crypt::OpenGPG code?

https://github.com/btrott/Crypt-OpenPGP/blob/77352f28bfa9f9ad9f31f8ac145b0be39c5addba/lib/Crypt/OpenPGP/Armour.pm#L142

indicates that you just need to add a 'Comment => $bmo_url' parameter to the Headers hash.

I request that the URL is the *only thing* in the Comment, since no further information is required and that provides the best usability (obvious clickable url on line 4 of the email).

Comment 1

[Gervase Markham [:gerv]]

Weird. I thought of this idea just the other day, then forgot it again :-)

Gerv

Comment 2

[:glob ✱]

Attachment: 1190476_1.patch

i performed some testing with atoll and this appears to do the trick.

Comment 3

[:Atoll]

Before:

-----BEGIN PGP MESSAGE-----
Version: Crypt::OpenPGP 1.04

hQIOA7Z/9NBBpcqLEAf/bMV+r9xTcPKkbUmoxzjFs8NlVQ/v4vyeAVF9AhTr70JP


After:

-----BEGIN PGP MESSAGE-----
Comment: http://bz/1190476/show_bug.cgi?id=888

hQMMA7Z/9NBBpcqLEAgAilS8GOEtWVvdLlFTxU1jd+8rH3zxiJUbIZbiTgTMXeBM


The message decrypts cleanly and to the same content as before.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8649705 [details] [diff] [review]
1190476_1.patch

Review of attachment 8649705 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   df1f6c9..667ecc3  master -> master