1190823 - Move OwningNonNull to from dom/ to xpcom/

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

This is more widely useful than just DOM.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8643018 [details] [diff] [review]
Patch

Review of attachment 8643018 [details] [diff] [review]:
-----------------------------------------------------------------

I think you uploaded the wrong patch.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8643032 [details] [diff] [review]
Patch

Review of attachment 8643032 [details] [diff] [review]:
-----------------------------------------------------------------

It would be great if you could fix the alphabetization of the headers in some of the files you modified, but since we don't have decent tools to do that, a follow-up bug for those is fine.

Comment 5

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I find :!sort in vim works well.  :)

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Green build-only try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d9f880a4ae3

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4ab7680520

Comment 8

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

NOTE TO SHERRIFFS: This patch changes the OwningNonNull.h header from mozilla/dom/OwningNonNull.h to mozilla/OwningNonNull.h, and moves the class out of the dom namespace.  So if any merged code has references to the old location/name, it will not build.  As an alternative to backing this patch out, you could just remove the "dom" bit.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac4ab7680520

Comment 10

[Boris Zbarsky [:bzbarsky]]

Updated documentation at https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#OwningNonNull