119085 - cache entries corrupted if size of metadata is zero

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[gordon]

nsCacheMetaData::UnflattenMetaData() returns an error when metadata size is
zero, causing the associated entry to be unusable.

Comment 1

[gordon]

Attachment: return NS_OK for size = 0.

Darin, I changed the patch to exit early on size==0 rather than change the
default return error to catch problems when the reported size doesn't match the
size implied by the data itself.

Comment 2

[Darin Fisher]

Comment on attachment 64899 [details] [diff] [review]
return NS_OK for size = 0.

sr=darin

Comment 3

[Radha on family leave (not reading bugmail)]

gordon: Is it possible to check this into the 0.9.8 branch? I'm attempting to
checkin my patch in to the branch this week and I need yours to maintain proper
functionality. Thanks,

Comment 4

[gordon]

I don't see bug 35340 listed as an important bug for 0.9.8.  Are you sure you're
going to get drivers approval?  That's all I need to check this in.  I would
rather check it in before they branch.  Are you ready to check in your patch?

Comment 5

[Radha on family leave (not reading bugmail)]

I'm working to get reviews right now for bug 35340. I'm also generating
momentum, so this  will be accepted into 0.9.8 branch.

Comment 6

[Radha on family leave (not reading bugmail)]

gordon: I just now had a word with jud. 35340 will not be going into the 0.9.8
branch. So, it is OK if you check this in the trunk for 0.9.9. sorry about the
confusion. 

Comment 7

[gordon]

patch checked in. Marking FIXED.