1190857 - Add loader alias to DevTools loader exports

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 1188401, many users of Loader.jsm are changed to store the `devtools` export (the loader object with lazy APIs) under the name `loader`, which matches what happens inside a module.

We should export this object as `loader` for real, so callers don't have to rename it everywhere.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

I had to rename existing variable whose name is `loader`  in frame script utils and loader.jsm.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4278c2855e

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8646426 [details] [diff] [review]
patch v1

Review of attachment 8646426 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/gDevTools.jsm
@@ +9,5 @@
>  const { classes: Cc, interfaces: Ci, utils: Cu } = Components;
>  
>  Cu.import("resource://gre/modules/XPCOMUtils.jsm");
>  Cu.import("resource://gre/modules/Services.jsm");
> +const {require, loader} = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});

Nit: spaces in braces (either change this one, or reverse Components above to match this)

::: browser/devtools/shared/frame-script-utils.js
@@ +11,1 @@
>              .getService(Ci.mozIJSSubScriptLoader);

Nit: fix indent

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9dca174c12f9

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9dca174c12f9