1191109 - Clean up stateWM vs. wm confusion in nsHTMLReflowState::GetHypotheticalBoxContainer

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

In nsHTMLReflowState::GetHypotheticalBoxContainer, we have two writing-modes -- wm and stateWM -- and we convert between them.

I think they're the writing-mode for the same frame, though (the containing block), so I don't think we actually need both (and I think we can assume they're the same).

So I think we can move...
  WritingMode wm = aFrame->GetWritingMode();
...into the "else" clause (the code for when we have no reflow-state for the containing block), and we can just rename "stateWM" to "wm" in the "if" clause. (and do away with unnecessary WM conversion)

http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsHTMLReflowState.cpp?rev=65c3a87e04fb#1020

Marking as depends-on bug 1183431 because this is in code that's touched by the patch there, and I don't want to bitrot jfkthame, so we shouldn't patch this until after bug 1183431 has landed.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Clean up use of writing-modes in GetHypotheticalBoxContainer, eliminating a redundant ConvertTo call

Comment 2

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=71926460f227

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8644543 [details] [diff] [review]
Clean up use of writing-modes in GetHypotheticalBoxContainer, eliminating a redundant ConvertTo call

Looks good -- thanks!

Comment 4

[Jonathan Kew [:jfkthame]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f4387ef8cabe8a17c490b3554206a5b7513f7945
changeset:  f4387ef8cabe8a17c490b3554206a5b7513f7945
user:       Jonathan Kew <[e-mail]>
date:       Wed Aug 12 11:02:02 2015 +0100
description:
Bug 1191109 - Clean up use of writing-modes in GetHypotheticalBoxContainer, eliminating a redundant ConvertTo call. r=dholbert

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f4387ef8cabe