1191529 - Remove JSIdArray and AutoIdArray

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: 1_remove_AutoIdArray_sm-v0.diff

JSIdArray is this wonderfully crufty piece of manual C-style memory mis-management that is still hanging on somehow. Its only user is JS_Enumerate. The actual work here happens into an AutoIdVector, after which we malloc and memcopy a second copy into a JSIdArray and return that so that the caller can root it with AutoId*Array*.

Instead, let's just have the caller pass in a handle to an IdVector. Unfortunately, AutoIdVector is not really a vector, so we can't avoid the copy yet, but this should be fixed soon when we remove AutoIdVector.

Comment 1

[Terrence Cole [:terrence]]

Attachment: 2_remove_AutoIdArray_gecko-v0.diff

Converting gecko to the new API was trivial: add an outparam and convert to standard SM return conventions.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8643972 [details] [diff] [review]
2_remove_AutoIdArray_gecko-v0.diff

I'm sure Andrew wants to review this ;)

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 8643970 [details] [diff] [review]
1_remove_AutoIdArray_sm-v0.diff

Review of attachment 8643970 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsatom.h
@@ -26,5 @@
> -    js::HeapId* begin() { return vector; }
> -    const js::HeapId* begin() const { return vector; }
> -    js::HeapId* end() { return vector + length; }
> -    const js::HeapId* end() const { return vector + length; }
> -};

Nice to see this go!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8da9d2fc8dd

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f8da9d2fc8dd